Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd client to v3.4.13 #94259

Merged
merged 1 commit into from Aug 28, 2020
Merged

Update etcd client to v3.4.13 #94259

merged 1 commit into from Aug 28, 2020

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Aug 26, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
We are bumping etcd client version to v3.4.13 in this PR. Then we can bump etcd server (used in testing and manifests) to the same version to pick up etcd-io/etcd#12242 which fixes etcd-io/etcd#12144 and etcd-io/etcd#12148.

Related:
#94141
#94102
kubernetes/kubeadm#2256

Does this PR introduce a user-facing change?:

Update etcd client side to v3.4.13

/sig api-machinery
/area etcd

cc @kubernetes/release-engineering @neolit123 @justaugustus @saschagrunert @BenTheElder @wojtek-t @wenjiaswe

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Aug 26, 2020
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Aug 26, 2020
@jingyih jingyih mentioned this pull request Aug 26, 2020
Merged
@neolit123
Copy link
Member

LGTM, thanks @jingyih

@jingyih
Copy link
Contributor Author

jingyih commented Aug 26, 2020

Can we still get this in Kubernetes v1.19?

@neolit123
Copy link
Member

Can we still get this in Kubernetes v1.19?

i don't think we can because 1.19 is releasing later today and usually new etcd needs to be tested in CI for a while.

@hasheddan
Copy link
Contributor

@jingyih @neolit123 v1.19 is now live

@jingyih
Copy link
Contributor Author

jingyih commented Aug 26, 2020

Got it. Thanks:)

/milestone v1.20

@k8s-ci-robot
Copy link
Contributor

@jingyih: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

Got it. Thanks:)

/milestone v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert
saschagrunert approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
@BenTheElder
Copy link
Member

BenTheElder commented Aug 26, 2020 •
edited

/test pull-kubernetes-conformance-kind-ga-only-parallel
edit: sorry, wrong PR!

@BenTheElder
Copy link
Member

/test pull-kubernetes-conformance-kind-ga-only-parallel

@BenTheElder
Copy link
Member

/retest

@BenTheElder
Copy link
Member

BenTheElder commented Aug 26, 2020 •
edited

/retest
#94263 (comment)

@jingyih
Copy link
Contributor Author

jingyih commented Aug 27, 2020

/retest

@wojtek-t
Copy link
Member

Milestone will be applied by release team later according to staged merge proposal.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyih, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@justaugustus justaugustus added this to the v1.20-phase-bug milestone Aug 27, 2020
@jingyih jingyih mentioned this pull request Aug 27, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Aug 28, 2020

does this actually matter on the client side? the permission check being fixed is run by the server, right?

@jingyih
Copy link
Contributor Author

jingyih commented Aug 28, 2020

does this actually matter on the client side? the permission check being fixed is run by the server, right?

You are correct. The fix is on server side. But I think it is a good idea to keep the client and server versions match.

@liggitt liggitt added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Aug 28, 2020
@liggitt liggitt modified the milestones: v1.20-phase-bug, v1.20 Aug 28, 2020
@liggitt
Copy link
Member

liggitt commented Aug 28, 2020

sure, just wanting to make sure this is characterized correctly

@jingyih
Copy link
Contributor Author

jingyih commented Aug 28, 2020

sure, just wanting to make sure this is characterized correctly

Oh I see. Thanks! Let me correct the PR description.

@k8s-ci-robot k8s-ci-robot merged commit 7f813a9 into kubernetes:master Aug 28, 2020
@jingyih jingyih mentioned this pull request Sep 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Upgrading from v3.4.9 to v3.4.10 requires manual action
9 participants
@jingyih @neolit123 @hasheddan @k8s-ci-robot @BenTheElder @wojtek-t @liggitt @saschagrunert @justaugustus