Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Snapshot to GA #95282

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Move Snapshot to GA #95282

merged 1 commit into from
Nov 12, 2020

Conversation

xing-yang
Copy link
Contributor

What type of PR is this?
/kind feature

Optionally add one or more of the following kinds if applicable:
/kind api-change

What this PR does / why we need it:
Marks VolumeSnapshotDataSource as GA for 1.20

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

VolumeSnapshotDataSource moves to GA in 1.20 release

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

-[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/177-volume-snapshot

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 4, 2020
@k8s-ci-robot
Copy link
Contributor

@xing-yang: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 4, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 4, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@xing-yang xing-yang force-pushed the snapshot_ga branch 3 times, most recently from 45aa852 to 4a28092 Compare October 5, 2020 01:51
@xing-yang
Copy link
Contributor Author

/assign @msau42

@xing-yang xing-yang mentioned this pull request Oct 12, 2020
Closed
@xing-yang
Copy link
Contributor Author

CC @yuxiangqian

@xing-yang
Copy link
Contributor Author

/assign @thockin

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2020
msau42
msau42 reviewed Oct 31, 2020
View reviewed changes
pkg/api/persistentvolumeclaim/util_test.go Outdated Show resolved Hide resolved
pkg/apis/core/types.go Outdated Show resolved Hide resolved
pkg/apis/core/types.go Show resolved Hide resolved
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@annajung annajung mentioned this pull request Nov 2, 2020
Merged
thockin
thockin reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@msau42 owns the LGTM

pkg/api/persistentvolumeclaim/util.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
msau42
msau42 reviewed Nov 3, 2020
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm, just some minor comments.

Also this is dependent on meeting the remaining GA criteria.
/hold

pkg/api/persistentvolumeclaim/util_test.go Outdated Show resolved Hide resolved
pkg/api/persistentvolumeclaim/util_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-integration

@xing-yang
Copy link
Contributor Author

@msau42 addressed your comments. PTAL.

@xing-yang
Copy link
Contributor Author

/assign @saad-ali

yuxiangqian
yuxiangqian reviewed Nov 11, 2020
View reviewed changes
Copy link
Contributor

@yuxiangqian yuxiangqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, lgtm

pkg/api/persistentvolumeclaim/util_test.go Show resolved Hide resolved
pkg/api/persistentvolumeclaim/util_test.go Show resolved Hide resolved
pkg/api/persistentvolumeclaim/util_test.go Show resolved Hide resolved
pkg/api/persistentvolumeclaim/util_test.go Show resolved Hide resolved
@xing-yang
Copy link
Contributor Author

@yuxiangqian addressed your comments. PTAL. Thanks.

@yuxiangqian
Copy link
Contributor

@yuxiangqian addressed your comments. PTAL. Thanks.

nvm, i missed the folded lines where "anyEnabled" has been covered. LGTM

saad-ali
saad-ali approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saad-ali
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit bffdc87 into kubernetes:master Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 12, 2020
@github-actions github-actions bot mentioned this pull request Nov 18, 2020
Open
@xing-yang
Copy link
Contributor Author

Just noticed that bot added sig/apps. This should be sig/storage.

@xing-yang
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 9, 2020
@xing-yang
Copy link
Contributor Author

/sig apps remove

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The label(s) sig/remove cannot be applied, because the repository doesn't have them

In response to this:

/sig apps remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@yuxiangqian yuxiangqian yuxiangqian left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali saad-ali approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@thockin thockin

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xing-yang @k8s-ci-robot @fejta-bot @yuxiangqian @saad-ali @thockin @msau42