set lastterminationstate for container status even when CRI fails to return termination (or any) data #95364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
k8s-ci-robot
added
area/kubelet
sig/node
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/kind bug |
k8s-ci-robot
added
priority/important-soon
|
/priority important-soon |
|
/assign |
pkg/kubelet/kubelet_pods.go
Outdated
| status.LastTerminationState.Terminated = &v1.ContainerStateTerminated{ | ||
| Reason: "ContainerStatusUnknown", | ||
| Message: "The container could not be located when the pod was deleted. The container used to be Running", | ||
| ExitCode: 138, // one more than 137 for the other case of missing containers |
There was a problem hiding this comment.
exit codes have meaning, i dont understand why 137 isnt used like https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/status/status_manager.go#L334
derekwaynecarr
requested changes
Oct 7, 2020
pkg/kubelet/kubelet_pods.go
Outdated
| status.LastTerminationState.Terminated = &v1.ContainerStateTerminated{ | ||
| Reason: "ContainerStatusUnknown", | ||
| Message: "The container could not be located when the pod was deleted. The container used to be Running", | ||
| ExitCode: 138, // one more than 137 for the other case of missing containers |
There was a problem hiding this comment.
exit codes have meaning, i dont understand why 137 isnt used like https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/status/status_manager.go#L334
|
/assign |
…return termination (or any) data
|
This took a little bit to review, but thank you for the clear comment thread. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no container is found when determining container status, then assuming it should be waiting seems plausible, but the pod phase status code requires that a previous termination be present. If we're offline long enough (or something removed the container?), then the previous termination may not be present. This next code block ensures that if the container was previously running then when that container status disappears, we can infer that it terminated even if we don't know the status code. By setting the lasttermination state we are able to leave the container status waiting and present more accurate data via the API.
This only impacts the path when the pod itself is being deleted to narrow the scope of change.