Make webhook retry backoff parameters configurable #95705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
tkashem
force-pushed
the
webhook-retry
branch
from
88d8718
to
7f1fcd3
Compare
k8s-ci-robot
added
area/test
sig/testing
tkashem
force-pushed
the
webhook-retry
branch
from
7f1fcd3
to
d9fbf6c
Compare
k8s-ci-robot
added
the
sig/cloud-provider
|
/retest |
tkashem
force-pushed
the
webhook-retry
branch
3 times, most recently
from
1f3d9eb
to
af47846
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
tkashem
force-pushed
the
webhook-retry
branch
from
af47846
to
c220782
Compare
|
/retest |
|
/assign @deads2k |
|
/retest |
1 similar comment
|
/retest |
tkashem
force-pushed
the
webhook-retry
branch
from
75fbcf4
to
dea1437
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
k8s-ci-robot
added
the
needs-rebase
Currently webhook retry backoff parameters are hard coded, we want to have the ability to configure the backoff parameters for webhook retry logic.
tkashem
force-pushed
the
webhook-retry
branch
from
dea1437
to
2f812c3
Compare
k8s-ci-robot
added
area/cloudprovider
and removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sftim
reviewed
Nov 2, 2020
Comment on lines
+40
to
+41
| // DefaultAuthWebhookRetryBackoff is the default backoff parameters for | ||
| // both authentication and authorization webhook used by the apiserver. |
There was a problem hiding this comment.
If a webhook returns a 5xx response that has Retry-After set, the client end (Kubernetes) does not pay attention to that.
Would it be OK to briefly mention in a comment that this implementation does not adjust behavior based on Retry-After?
(to be clear - it's OK not to check that header; maybe a future PR can start checking that response header)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dims, sjenning, sttts, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sgreene570
added a commit
to sgreene570/router
that referenced
this pull request
Dec 11, 2020
kubernetes/kubernetes#95705 added the requirement for specifying the `WebhookRetryBackoff` field in authorizerfactory.DelegatingAuthorizerConfig{} struct used for metrics authorization. This commit explicitly sets the field to the previous implicitly used defaults, available in "k8s.io/apiserver/pkg/server/options". This commit is purely for compatability with kubernetes apiserver 1.20 and does not change behavior.
sgreene570
added a commit
to sgreene570/router
that referenced
this pull request
Dec 14, 2020
kubernetes/kubernetes#95705 added the requirement for specifying the `WebhookRetryBackoff` field in authorizerfactory.DelegatingAuthenticatorConfig{} struct used for metrics authorization. This commit explicitly sets the field to the previous implicitly used defaults, available in "k8s.io/apiserver/pkg/server/options". This commit is purely for compatability with kubernetes apiserver 1.20 and does not change behavior.
sgreene570
added a commit
to sgreene570/router
that referenced
this pull request
Dec 14, 2020
pkg/cmd/infra/router/template.go: kubernetes/kubernetes#95705 added the requirement for specifying the `WebhookRetryBackoff` field in authentication/authorizer DelegatingAuthenticatorConfig{} struct used for metrics authentication. This commit explicitly sets the field to the previous implicitly used defaults, available in "k8s.io/apiserver/pkg/server/options". This commit is purely for compatability with kubernetes apiserver 1.20 and does not change behavior.
sgreene570
added a commit
to sgreene570/router
that referenced
this pull request
Dec 14, 2020
pkg/cmd/infra/router/template.go: kubernetes/kubernetes#95705 added the requirement for specifying the `WebhookRetryBackoff` field in authentication/authorizer DelegatingAuthenticatorConfig{} struct used for metrics authentication. This commit explicitly sets the field to the previous implicitly used defaults, available in "k8s.io/apiserver/pkg/server/options". This commit is purely for compatability with kubernetes apiserver 1.20 and does not change behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently webhook retry backoff parameters are hard coded, we want to have the ability to configure the backoff parameters for webhook retry logic.
The objective of this PR is to make the backoff parameters configurable only. So the default that is being used today should still be in effect.
Does this PR introduce a user-facing change?: