New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906860: Bump for kube 1.20 #236
Bug 1906860: Bump for kube 1.20 #236
Conversation
@sgreene570: This pull request references Bugzilla bug 1906860, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Concerning error in router logs: |
e685902
to
6d76cec
Compare
|
@sgreene570: This pull request references Bugzilla bug 1906860, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
ade8a65
to
13b0455
Compare
pkg/cmd/infra/router/template.go: kubernetes/kubernetes#95705 added the requirement for specifying the `WebhookRetryBackoff` field in authentication/authorizer DelegatingAuthenticatorConfig{} struct used for metrics authentication. This commit explicitly sets the field to the previous implicitly used defaults, available in "k8s.io/apiserver/pkg/server/options". This commit is purely for compatability with kubernetes apiserver 1.20 and does not change behavior.
13b0455
to
a3f0f9a
Compare
/retest |
|
/retest |
2 similar comments
/retest |
/retest |
@sgreene570: This pull request references Bugzilla bug 1906860, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sgreene570: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1906860 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR bumps the router's go dependencies for the kubernetes 1.20 release.
kubernetes/kubernetes#95705 added a breaking change in kube 1.20. Commit
a3f0f9a
addresses this by explicitly using the default back off values inpkg/cmd/infra/router/template.go
. Not specifying theWebhookRetryBackoff
field inDelegatingAuthorizerConfig
/DelegatingAuthenticatorConfig
will cause a panic (see upstream PR).