New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly quote flags passed to Cluster Autoscaler #95766
Conversation
@towca: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a4b5ea0
to
33b0a81
Compare
For some context, this bug has been causing all Cluster Autoscaler e2e tests to fail for quite some time: https://testgrid.k8s.io/sig-autoscaling-cluster-autoscaler#gci-gce-autoscaling. |
/assign @MaciekPytel |
/retest |
33b0a81
to
c69fc7a
Compare
/test pull-kubernetes-bazel-build |
In the current implementation, the flags are not put between quotes, and so the Cluster Autoscaler manifest doesn't parse as valid JSON.
c69fc7a
to
236ade0
Compare
/test pull-kubernetes-verify |
/test pull-kubernetes-node-e2e |
/test pull-kubernetes-bazel-build |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kind-ipv6 |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
/test pull-kubernetes-conformance-kind-ga-only-parallel |
/test pull-kubernetes-e2e-kind-ipv6 |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
In the current implementation, the flags are not put between quotes,
and so the Cluster Autoscaler manifest doesn't parse as valid JSON.
/kind bug