New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shellcheck issues in cluster/gce/gci/master-helper.sh #95865
Fix shellcheck issues in cluster/gce/gci/master-helper.sh #95865
Conversation
Hi @joakimr-axis. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @cheftako @pwittrock |
This PR brings @gavinfish's closed-due-to-inactivity PR #88582 back to life with a few updates. |
/ok_to_test |
/ok-to-test |
Based on PR 88582 by gavinfish that was closed due to inactivity. Contains a few updates. Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
/milestone v1.21 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, joakimr-axis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix shellcheck failures in cluster/gce/gci/master-helper.sh.
Which issue(s) this PR fixes:
Ref #72956
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: