Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/cmd/auth under staging/src/k8s.io/kubectl/pkg/cmd/auth #96145

Merged
merged 1 commit into from Nov 3, 2020
Merged

Move pkg/kubectl/cmd/auth under staging/src/k8s.io/kubectl/pkg/cmd/auth #96145

merged 1 commit into from Nov 3, 2020

Conversation

ingvagabund
Copy link
Contributor

@ingvagabund ingvagabund commented Nov 3, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Move pkg/kubectl/cmd/auth under staging/src/k8s.io/kubectl/pkg/cmd/auth to get closer to moving all commands under k8s.io/kubectl eventually.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims, justaugustus and a team November 3, 2020 09:35
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 3, 2020
@ingvagabund ingvagabund force-pushed the move-pkg-kubectl-cmd-auth-under-kubectl-staging branch 2 times, most recently from 62d288c to 3df5c42 Compare November 3, 2020 12:14
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2020
@ingvagabund
Copy link
Contributor Author

/retest

@soltysh soltysh mentioned this pull request Nov 3, 2020
Closed
@ingvagabund ingvagabund force-pushed the move-pkg-kubectl-cmd-auth-under-kubectl-staging branch from 3df5c42 to d3726b9 Compare November 3, 2020 14:34
@ingvagabund
Copy link
Contributor Author

/retest

soltysh
soltysh approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority backlog
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@sttts
Copy link
Contributor

sttts commented Nov 3, 2020

/approve

@soltysh
Copy link
Contributor

soltysh commented Nov 3, 2020

I'm manually approving, since the remaining change is related moving kubectl to staging.

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ingvagabund, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c82d5ee into kubernetes:master Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 3, 2020
@ash2k ash2k mentioned this pull request Nov 3, 2020
Open
@ingvagabund ingvagabund deleted the move-pkg-kubectl-cmd-auth-under-kubectl-staging branch November 3, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dims dims Awaiting requested review from dims

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ingvagabund @sttts @soltysh @k8s-ci-robot