Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snapshot Controller e2e metric tests #96299

Merged
merged 1 commit into from May 23, 2021
Merged

Add Snapshot Controller e2e metric tests #96299

merged 1 commit into from May 23, 2021

Conversation

ggriffiths
Copy link
Member

@ggriffiths ggriffiths commented Nov 6, 2020 •
edited

Signed-off-by: Grant Griffiths ggriffiths@purestorage.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Adds e2e tests for snapshot controller metrics
  • Adds framework for grabbing snapshot controller metrics

Which issue(s) this PR fixes:
Part of kubernetes-csi/external-snapshotter#151

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
n/a

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2020
@ggriffiths
Copy link
Member Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2020
@xing-yang
Copy link
Contributor

/assign

@ggriffiths ggriffiths force-pushed the snapshot_controller_metrics_e2e_tests branch 2 times, most recently from 0ee1c90 to cb903e3 Compare November 9, 2020 18:05
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Nov 9, 2020
@ggriffiths ggriffiths force-pushed the snapshot_controller_metrics_e2e_tests branch 3 times, most recently from 5ea7dc1 to 961cbf7 Compare November 9, 2020 20:38
@ggriffiths ggriffiths force-pushed the snapshot_controller_metrics_e2e_tests branch from 2147b4c to e50d31d Compare November 9, 2020 22:23
@ggriffiths ggriffiths force-pushed the snapshot_controller_metrics_e2e_tests branch from 527baf6 to e7e7fe5 Compare May 17, 2021 17:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@ggriffiths
Copy link
Member Author

Added a change to only show the metrics table when waitForSnapshotControllerMetric fails. This will be helpful to keep if any flake happens.

@ggriffiths
Copy link
Member Author

/test pull-kubernetes-e2e-kind

@ggriffiths ggriffiths force-pushed the snapshot_controller_metrics_e2e_tests branch from e7e7fe5 to 2be470c Compare May 17, 2021 18:30
@ggriffiths
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@ggriffiths
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-slow

@ggriffiths
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-csi-serial

@ggriffiths
Copy link
Member Author

ggriffiths commented May 18, 2021 •
edited

Storage tests seem to be flaking on unrelated tests. Trying once more today and then I'll hold off until things passing on the test grid.
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-csi-serial

@ggriffiths
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-csi-serial

@msau42
Copy link
Member

msau42 commented May 21, 2021

From the latest run, is this msg ok?

I0518 19:24:46.409] �[1mSTEP�[0m: check for delete metrics
I0518 19:24:46.464] May 18 19:24:46.463: INFO: failed to find metric value: did not find metric for key csi-mock-csi-mock-volumes-7404_snapshot_controller_operation_total_seconds_count_DeleteSnapshot_success_pre-provisioned

Add Snapshot Controller e2e metric tests
564e531 
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
@ggriffiths ggriffiths force-pushed the snapshot_controller_metrics_e2e_tests branch from 2be470c to 564e531 Compare May 21, 2021 06:29
@ggriffiths
Copy link
Member Author

Yeah, that was being logged during the retries in waitForSnapshotControllerMetric. I've removed it to avoid confusion.

@ggriffiths
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gce-csi-serial

@msau42
Copy link
Member

msau42 commented May 21, 2021

/lgtm
/approve

The pd test failures are being fixed in #102212

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@xing-yang
Copy link
Contributor

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

5 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 23, 2021 •
edited

@ggriffiths: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-storage-snapshot 564e531 link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-csi-serial 564e531 link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d790366 into kubernetes:master May 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@logicalhan logicalhan Awaiting requested review from logicalhan

@xing-yang xing-yang Awaiting requested review from xing-yang

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

@msau42 msau42 Awaiting requested review from msau42

Assignees

@logicalhan logicalhan

@xing-yang xing-yang

@yuxiangqian yuxiangqian

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet