Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduating AppProtocol to GA #96327

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Graduating AppProtocol to GA #96327

merged 1 commit into from
Nov 12, 2020

Conversation

robscott
Copy link
Member

@robscott robscott commented Nov 7, 2020

What type of PR is this?
/kind feature
/kind api-change

What this PR does / why we need it:
This graduates the AppProtocol field on Services and Endpoints to GA.

Does this PR introduce a user-facing change?:

AppProtocol is now GA for Endpoints and Services. The ServiceAppProtocol feature gate will be deprecated in 1.21.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Enhancement Issue: kubernetes/enhancements#1507

/sig network
/cc @bowei
/assign @thockin
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 7, 2020
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2020
@robscott
Copy link
Member Author

robscott commented Nov 7, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

thockin
thockin reviewed Nov 9, 2020
View reviewed changes
pkg/controller/endpoint/endpoints_controller.go
Name: servicePort.Name,
Port: int32(portNum),
Protocol: servicePort.Protocol,
AppProtocol: servicePort.AppProtocol,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have this equivalent in EPSlice? Why not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - it actually predated all of this (v1.17). This feature gate guards a later addition of the same field to Services and Endpoints: https://github.com/kubernetes/kubernetes/blob/release-1.17/staging/src/k8s.io/api/discovery/v1alpha1/types.go#L142-L148.

thockin
thockin reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2020
@robscott robscott mentioned this pull request Nov 9, 2020
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@robscott
Copy link
Member Author

robscott commented Nov 9, 2020

@thockin I've fixed the failing tests - missed removing a feature gate check. PTAL.

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Nov 10, 2020
Closed
@bowei
Copy link
Member

bowei commented Nov 12, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4b46d44 into kubernetes:master Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 12, 2020
@robscott robscott deleted the app-protocol-ga branch March 11, 2021 04:55
@robscott robscott mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @fejta-bot @bowei @k8s-ci-robot @thockin