Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet/eviction: eliminate redundant allocations when handling eventfd #96828

Merged
merged 1 commit into from
Mar 1, 2022
Merged

kubelet/eviction: eliminate redundant allocations when handling eventfd #96828

merged 1 commit into from
Mar 1, 2022

Conversation

panjf2000
Copy link
Contributor

@panjf2000 panjf2000 commented Nov 24, 2020 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Eliminate the unnecessary memory allocations when reading from eventfd.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 24, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @panjf2000!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @panjf2000. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 24, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 24, 2020
@panjf2000
Copy link
Contributor Author

panjf2000 commented Nov 25, 2020 •
edited

@mrunalp @krmayankk Have some time to take a look at this?

@panjf2000 panjf2000 force-pushed the opt-epoll-eventfd branch 2 times, most recently from 71aae08 to 9efe279 Compare November 25, 2020 10:21
@panjf2000
Copy link
Contributor Author

/assign @sjenning

@panjf2000
Copy link
Contributor Author

Please take a look at this PR, thanks! @sjenning @mrunalp @krmayankk

@panjf2000
Copy link
Contributor Author

panjf2000 commented Dec 2, 2020 •
edited

Could somebody take a glance at this? It's been more than a week!

@panjf2000
Copy link
Contributor Author

panjf2000 commented Dec 24, 2020 •
edited

The new pattern to create epoll instance is more robust, which is widely used among several world-renowned open-source projects:

@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 6, 2021
@ehashman ehashman moved this from Needs Reviewer to Triage in SIG Node PR Triage Jan 6, 2021
@ehashman
Copy link
Member

/ok-to-test
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2021
@panjf2000
Copy link
Contributor Author

Any updates?

@ffromani
Copy link
Contributor

the e2e lanes look good, not sure what's going on with EasyCLA

@panjf2000
Copy link
Contributor Author

the e2e lanes look good, not sure what's going on with EasyCLA

Anything I can do to fix it?

@ffromani
Copy link
Contributor

the e2e lanes look good, not sure what's going on with EasyCLA

Anything I can do to fix it?

We probably need to retrigger the lane. I don't have permissions to do so. Uploading again the change, perhaps after a rebase on top of current branch, may unblock it.

@SergeyKanzhelev
Copy link
Member

let me try to close and re-open the PR. Sometimes it helps

/close

SIG Node PR Triage automation moved this from Needs Reviewer to Done Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Closed this PR.

In response to this:

let me try to close and re-open the PR. Sometimes it helps

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev
Copy link
Member

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Done to Triage Feb 22, 2022
SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a trivial change in it's current form

/lgtm

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Approver in SIG Node PR Triage Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@panjf2000
Copy link
Contributor Author

@panjf2000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind 3033a64 link true /test pull-kubernetes-e2e-kind
pull-kubernetes-integration 3033a64 link true /test pull-kubernetes-integration
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Looked like two unrelated failures?

@ffromani
Copy link
Contributor

/retest-required

@panjf2000
Copy link
Contributor Author

Everything seems fine, could we merge it?
@fromanirh @SergeyKanzhelev

@ffromani
Copy link
Contributor

Everything seems fine, could we merge it? @fromanirh @SergeyKanzhelev

You got a LGTM, but you need an approver for the change: see #96828 (comment)

@panjf2000
Copy link
Contributor Author

Everything seems fine, could we merge it? @fromanirh @SergeyKanzhelev

You got a LGTM, but you need an approver for the change: see #96828 (comment)

@mrunalp @sjenning

@panjf2000
Copy link
Contributor Author

@Random-Liu @dchen1107 @derekwaynecarr @yujuhong @klueska
Please take a look at this whoever is available, thanks~

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, panjf2000, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5d6a793 into kubernetes:master Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 1, 2022
@panjf2000 panjf2000 deleted the opt-epoll-eventfd branch March 2, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@ffromani ffromani Awaiting requested review from ffromani

Assignees

@sjenning sjenning

@SergeyKanzhelev SergeyKanzhelev

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet