Aggressively delete a cluster template if it exists. #9702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| echo "Instance template ${1} already exists; deleting." >&2 | ||
| if ! gcloud compute instance-template delete "$1" --project "${PROJECT}" &>/dev/null; then | ||
| echo -e "${color_yellow}Failed to delete existing instance template" >&2 |
There was a problem hiding this comment.
This should end with ${color_norm}
|
LGTM w/ nits |
|
Comments addressed, ptal. |
|
I'm going to merge this, as this problem is currently breaking a number of e2e runs. |
brendandburns
added a commit
that referenced
this pull request
Jun 12, 2015
Aggressively delete a cluster template if it exists.
|
Sorry for not getting back, but was truly LGTM. I'll add the label for posterity :-) |
mbforbes
added
the
lgtm
|
GCE e2e build/test failed for commit e920e456f7aadd30755330dec32152f6f3c4ebf8. |
|
GCE e2e build/test passed for commit a44f36b295d947c1bab7389802fc0b74effff221. |
|
GCE e2e build/test failed for commit d91fe7c2cf5e9b8d6d6c6d7232d2e50cdb76e809. |
|
GCE e2e build/test failed for commit dcb09e7. |
|
Root cause #9016. More fixes to come. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbforbes @ixdy @quinton-hoole