Add missing gcloud --project flags introduced by PR #9016 #9738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sig/cluster-lifecycle
|
LGTM. |
roberthbailey
added
the
lgtm
ArtfulCoder
removed
the
lgtm
ghost
added
lgtm
ghost
mentioned this pull request
|
GCE e2e build/test failed for commit 58885c7. |
|
OK, I've tested this extensively across multiple GCE projects, both default and not, and it seems to work fine now. Ready for merge. Re-adding the LGTM tag that I removed earlier. |
ghost
added
the
lgtm
fabioy
added a commit
that referenced
this pull request
Jun 15, 2015
Add missing gcloud --project flags introduced by PR #9016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet, but please review. I'm busy running e2e tests locally to confirm.
cc @brendandburns @goltermann @ixdy @roberthbailey
Fixes #9016 #9719 #9702 and others.