Make admission errors clearer #9774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekwaynecarr PTAL |
|
GCE e2e build/test failed for commit 2040272f29081239fe810f0e66a25fb5d4bdbcc9. |
|
Much clearer :-) |
derekwaynecarr
added
the
lgtm
|
@k8s-bot retest this please |
|
GCE e2e build/test failed for commit 2040272f29081239fe810f0e66a25fb5d4bdbcc9. |
|
@k8s-bot retest this please |
|
GCE e2e build/test failed for commit 2040272f29081239fe810f0e66a25fb5d4bdbcc9. |
|
GCE e2e build/test passed for commit 87f8497. |
saad-ali
added a commit
that referenced
this pull request
Jun 17, 2015
Make admission errors clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the name can't be determined because the object doesn't have ObjectMeta, return the original error (same as if the object is nil). Otherwise a confusing message is returned that doesn't indicate the actual reason admission rejected the object.