Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick part of #97451: fix nodeport quota check failure during c… #97830

Merged
merged 1 commit into from Jan 8, 2021
Merged

cherry-pick part of #97451: fix nodeport quota check failure during c… #97830

merged 1 commit into from Jan 8, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 8, 2021 •
edited

What type of PR is this?
/kind bug
/sig network
/triage accepted

What this PR does / why we need it:
Cherry pick of #97826 (which is part of #97451) on release-1.17.

Which issue(s) this PR fixes:
Fixes #97437

Special notes for your reviewer:

I would recommend picking the zero portion of it to 1.17-1.20
per #97451 (comment)

Does this PR introduce a user-facing change?:

fix counting error in service/nodeport/loadbalancer quota check

@pacoxu
cherry-pick part of kubernetes#97451: fix nodeport quota check failur…
2c222ce 
…e during creating clusterip

Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jan 8, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 8, 2021
@aojea
Copy link
Member

aojea commented Jan 8, 2021

/lgtm
/assign @liggitt @cpanato

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2021
@liggitt
Copy link
Member

liggitt commented Jan 8, 2021

/priority important-soon
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2021
hasheddan
hasheddan approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 8, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6eaeb5f into kubernetes:release-1.17 Jan 8, 2021
@pacoxu pacoxu deleted the automated-cherry-pick-of-#97826-upstream-release-1.17 branch June 23, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@cpanato cpanato

@aojea aojea

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacoxu @aojea @liggitt @k8s-ci-robot @hasheddan @cpanato