kubectl: migrate $HOME/.kube to $HOME/.config/kube

[dougsland]

kubectl: migrate $HOME/.kube to $HOME/.config/kube

This patch implements the migration config from $HOME/.kube to
use XDG Base Directory Specification. The recommended
path now will be $HOME/.config/kube.

KEP: kubernetes/enhancements#2111

Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

[k8s-ci-robot]

@dougsland: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dougsland
To complete the pull request process, please assign caesarxuchao after the PR has been reviewed.
You can assign the PR to them by writing /assign @caesarxuchao in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• staging/src/k8s.io/client-go/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dougsland]

/sig cli

[dougsland]

/retest

[dougsland]

/test pull-kubernetes-e2e-gce-100-performance

[dougsland]

/test pull-kubernetes-e2e-gce-ubuntu-containerd

[pacoxu]

/retest

[dougsland]

/retest

[rikatz]

/kind feature
/priority backlog

[dougsland]

/retest

[dougsland]

/retest

[dougsland]

/retest

[liggitt]

/hold

this causes compatibility issues for client-go consumers

[caesarxuchao]

/cc @lavalamp
/triage accepted

[lavalamp]

This migration seems super painful, what is the benefit? The KEP states that it's a non-goal to "Deprecate any file under $HOME/.kube/"? The KEP is also not merged yet?

[lavalamp]

Even just adding a new place to search has the potential to be very confusing to users and e.g. change behavior should that "new" location somehow already exist on their system.

[dougsland]

Hi @lavalamp. Thanks for your review.

This migration seems super painful, what is the benefit?

Use the XDG Spec as must of programs use these days. Users have been asking. However, I will state all possibilities in the KEP in a few minutes as Jordan requested. They can even use:

 export KUBECONFIG=$HOME/.config/kube/config

The KEP states that it's a non-goal to "Deprecate any file under
$HOME/.kube/"?

Yes, the patch won't create new files names.

The KEP is also not merged yet?

No, people are reviewing.

[dougsland]

Even just adding a new place to search has the potential to be very confusing to users and e.g. change behavior should that
"new" location somehow already exist on their system.

It should documented, also that's why we have this code in the patch reusing code:

-               data, err := ioutil.ReadFile(source)
+               config, err := LoadFromFile(source)
                if err != nil {
                        return err
                }
-               // destination is created with mode 0666 before umask
-               err = ioutil.WriteFile(destination, data, 0666)
+               err = WriteToFile(*config, destination)
                if err != nil {

[k8s-ci-robot]

@dougsland: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd	67687a6	link	/test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce-100-performance	67687a6	link	/test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lavalamp]

I read the comments here, and I don't follow the argument for why the disruption is worth the benefit. I would vote against doing this.

Improving the existing documentation is fine.

[dougsland]

adding some other folks from sig-cli to the thread:
/cc @pwittrock
/cc @rikatz

[liggitt]

I read the comments here, and I don't follow the argument for why the disruption is worth the benefit. I would vote against doing this.

Improving the existing documentation is fine.

I agree with this.

[justinsb]

I've previously asked for the ability to support a directory of per-cluster kubeconfigs. Perhaps we could support a directory of kubeconfigs under ~/.config/kube/?

[dougsland]

I've previously asked for the ability to support a directory of per-cluster kubeconfigs. Perhaps we could support a
directory of kubeconfigs under ~/.config/kube/?

@justinsb that's a good idea.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[dougsland]

The k8s community decided to not move forward with the KEP regarding this PR.
Thanks everyone involved, closing the PR for now. Feel free to reach me via slack or email, if you have any questions.