Update pkg/api/testapi because namespace is always in the path now #9835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 4e531b826d4c349e8463cf71243aa4ce0a2c95c6. |
|
@lavalamp @smarterclayton who wants this PR? |
|
I can take this. |
| } | ||
| // Resource names in v1beta3 are lower case. |
There was a problem hiding this comment.
Can change this to "Resource names are lower case"
|
LGTM, module comments |
…we remove v1beta1/2
caesarxuchao
force-pushed
the
remove-testapi-nsQuery
branch
from
4e531b8
to
a309d3e
Compare
|
Thank you @nikhiljindal! Updated, PTAL. |
|
LGTM, thanks! |
nikhiljindal
added
the
lgtm
|
GCE e2e build/test passed for commit a309d3e. |
saad-ali
added a commit
that referenced
this pull request
Jun 16, 2015
Update pkg/api/testapi because namespace is always in the path now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8087
@nikhiljindal @bgrant0607 @krousey