New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #97700: OWNERS: Update SIG Release aliases #98369
Automated cherry pick of #97700: OWNERS: Update SIG Release aliases #98369
Conversation
We're currently only using this for changelog approvals and those should really be handled by relnotes + RelEng. Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com> Co-authored-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@hasheddan: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
/retest |
/assign @liggitt |
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
4e82f16
to
692caa5
Compare
do we want to pick #98701 instead so that sig-release can manage this themselves going forward? |
@liggitt yep in my queue for today 👍 |
Given we're pulling the relnotes team into review, the changes to reviewers will happen a little more frequently, which means we'll have the same issue of needing a top-level approver to do updates that we were trying to avoid by creating the subdirectory in the first place. Signed-off-by: Stephen Augustus <foo@auggie.dev> (cherry picked from commit 5639cd9)
Dan and Sascha are senior Release Managers, SIG Release leadership, and have already been giving thoughtful reviews of the content in this directory. Adding them as reviewers to spread the load of SIG Release eyes on content. Signed-off-by: Stephen Augustus <foo@auggie.dev> (cherry picked from commit 1a43c65)
/approve will leave lgtm to sig-release reviewer |
/assign @justaugustus |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
Cherry pick of #97700 on release-1.20.
#97700: OWNERS(sig-release): Remove SIG Release approvers alias
For details on the cherry pick process, see the cherry pick requests page.