-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSA for APIService #98576
Fix SSA for APIService #98576
Conversation
Hi @kevindelgado. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
/triage accepted |
@kevindelgado: The label In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevindelgado, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@kevindelgado Thanks for fixing this issue. I came across it when switching our controller to server-side apply. Is there any plan to backport this fix to k8s versions like 1.18, or 1.17? Our controllers need to work on clusters with those versions. |
@Liujingfang1 I've made an issue to track it and will try to look into backporting it shortly. #99046 |
containing an array of `ports`. The logic was added in March 2021 as a workaround for a known k8s issue, which causes getting the declared fields for k8s objects containing an array of `ports` to fail. The fixes to the k8s issue have been merged into k8s 1.20 and 1.21: 1) kubernetes/kubernetes#96317 (merged in 1.20) 2) kubernetes/kubernetes#98576 (merged in 1.21). k8s 1.21 is no longer supported on GKE and Anthos: 1) GKE release schedule: https://cloud.google.com/kubernetes-engine/docs/release-schedule 2) Anthos version and upgrade support: https://cloud.google.com/anthos/docs/version-and-upgrade-support Therefore, we can remove the logic and related unit tests. We can keep the e2e test to make sure this change does not break things.
containing an array of `ports`. The logic was added in March 2021 as a workaround for a known k8s issue, which causes getting the declared fields for k8s objects containing an array of `ports` to fail. The fixes to the k8s issue have been merged into k8s 1.20 and 1.21: 1) kubernetes/kubernetes#96317 (merged in 1.20) 2) kubernetes/kubernetes#98576 (merged in 1.21). k8s 1.21 is no longer supported on GKE and Anthos: 1) GKE release schedule: https://cloud.google.com/kubernetes-engine/docs/release-schedule 2) Anthos version and upgrade support: https://cloud.google.com/anthos/docs/version-and-upgrade-support Therefore, we can remove the logic and related unit tests. We can keep the e2e test to make sure this change does not break things.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It removes the code to nil out the OpenAPIConfig on the aggregator server so that SSA requests are routed properly for the apiservices resource.
Which issue(s) this PR fixes:
Fixes #89264