Eliminate possible infinite loop in exec #9890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user starts an exec session with a shell and leaves it idle long enough, they will eventually hit the Kubelet's HTTP server's read/write timeout of 5 minutes. At this time, the StartExec call to Docker exits, but if the user requested a TTY, the exec'd process does not exit. After StartExec finishes, we try to determine the exit code of the exec'd process, but in this case, we'll never get it. This change exits the loop after 5 tries if the process is still running.
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
LGTM - should be candidate for 1.0 due to leaking goroutines |
|
And post 1.0, we should try to find something other than 'docker exec' if possible. |
|
@k8s-bot test this please |
|
GCE e2e build/test passed for commit 7748a02. |
saad-ali
added a commit
that referenced
this pull request
Jun 16, 2015
Eliminate possible infinite loop in exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user starts an exec session with a shell and leaves it idle long
enough, they will eventually hit the Kubelet's HTTP server's read/write
timeout of 5 minutes. At this time, the StartExec call to Docker exits,
but if the user requested a TTY, the exec'd process does not exit.
After StartExec finishes, we try to determine the exit code of the
exec'd process, but in this case, we'll never get it. This change exits
the loop after 5 tries if the process is still running.