Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: Move tests into test/e2e/node package #98983

Merged
merged 1 commit into from
Mar 2, 2021
Merged

test/e2e: Move tests into test/e2e/node package #98983

merged 1 commit into from
Mar 2, 2021

Conversation

navidshaikh
Copy link
Member

@navidshaikh navidshaikh commented Feb 11, 2021 •
edited

What type of PR is this?

/kind cleanup
/priority important-soon

What this PR does / why we need it:

As part of a reliability working group effort the workstream of marking tests with SIG-identifier attribute has started. https://groups.google.com/g/kubernetes-sig-node/c/dVaNhlgT9CU/m/HXwY6slvAQAJ
Move test/e2e/examples.go to test/e2e/node and assign sig-node ownership.

Which issue(s) this PR fixes:

ref #98326

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 11, 2021
@navidshaikh navidshaikh mentioned this pull request Feb 11, 2021
Closed
wojtek-t
wojtek-t reviewed Feb 11, 2021
View reviewed changes
test/e2e/gke_node_pools.go Outdated Show resolved Hide resolved
test/e2e/node/recreate_node.go Outdated Show resolved Hide resolved
ehashman
ehashman reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/triage accepted

test/e2e/gke_node_pools.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 11, 2021
@navidshaikh navidshaikh mentioned this pull request Feb 15, 2021
Closed
@navidshaikh
Copy link
Member Author

/retitle Add sig-node tag for e2e tests

@navidshaikh
Copy link
Member Author

/retest

ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:

@navidshaikh
Copy link
Member Author

/retest

the following error keep popping

 ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:
- The resource 'projects/k8s-infra-e2e-boskos-058/regions/us-west1/addresses/bootstrap-e2e-master-ip' was not found
Could not detect Kubernetes master node.  Make sure you've launched a cluster with 'kube-up.sh'

@aojea
Copy link
Member

aojea commented Feb 25, 2021

indeed it was failing constantly https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-node-e2e

@aojea
Copy link
Member

aojea commented Feb 25, 2021

🤔

W0225 09:40:14.934] F0225 09:40:14.934240 5572 run_remote.go:242] Could not retrieve a image based on image regex "" and family "cos-89-lts": found zero images based on regex "" and family "cos-89-lts" in project "cos-cloud"

@aojea
Copy link
Member

aojea commented Feb 25, 2021

@pacoxu is this #98983 (comment) something you have recently fixed with kubernetes/test-infra#21022?

@wojtek-t
Copy link
Member

yes - this was merged couple minutes ago.

@wojtek-t
Copy link
Member

@SergeyKanzhelev - can you please lgtm on behalf of SIG node?

@wojtek-t
Copy link
Member

This LGTM, but I would like someone from SIG-node officially stamp it.

spiffxp
spiffxp suggested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to change but otherwise LGTM (would like approval from Node though)

test/e2e/node/examples.go Outdated Show resolved Hide resolved
test/e2e/node/examples.go Outdated Show resolved Hide resolved
@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2021

/test pull-kubernetes-e2e-kind

spiffxp
spiffxp approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Want /lgtm from sig-node

SIG Node CI/Test Board automation moved this from PRs - Review in progress to PRs - Reviewer lgtm'd Feb 25, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2021
@navidshaikh
test/e2e: Move tests into test/e2e/node package
e61f790 
 - assign sig-node ownership
 - Fix import aliases in test/e2e/node/examples.go
 - Fix merge conflicts in test/e2e/BUILD

Signed-off-by: Navid Shaikh <shaikhnavid14@gmail.com>
@navidshaikh
Copy link
Member Author

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2021
spiffxp
spiffxp approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 2, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SergeyKanzhelev
Copy link
Member

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Mar 2, 2021

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 5b8c1b2 into kubernetes:master Mar 2, 2021
SIG Node CI/Test Board automation moved this from PRs - Reviewer lgtm'd to Done Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 2, 2021
@navidshaikh navidshaikh deleted the pr/98326-leftover-part branch March 3, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@ehashman ehashman ehashman left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@spiffxp spiffxp spiffxp approved these changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@spiffxp spiffxp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Triage
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@navidshaikh @k8s-ci-robot @aojea @wojtek-t @spiffxp @SergeyKanzhelev @neolit123 @ehashman @derekwaynecarr @dchen1107