Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #93196: #94438: #94653: #95867: #96294: #96330: #96360: #96843: #99051

Closed
wants to merge 18 commits into from
Closed

Automated cherry pick of #93196: #94438: #94653: #95867: #96294: #96330: #96360: #96843: #99051

wants to merge 18 commits into from

Conversation

jingxu97
Copy link
Contributor

Cherry pick of #93196 #94438 #94653 #95867 #96294 #96330 #96360 #96843 on release-1.19.

#93196: Minor cleanup in snapshot test suite.
#94438: tests: Refactors agnhost image pod usage in tests
#94653: Tolerate NotFound errors when deleting snapshots
#95867: Log PodExec stdout + stderr
#96294: Separate in-tree gcepd driver for windows
#96330: Modify storage snapshottable and disruptive test for Windows
#96360: Update storage test suits for Windows
#96843: Remove unnecessary snapshot ability check

For details on the cherry pick process, see the cherry pick requests page.

Andi Li and others added 18 commits February 12, 2021 17:47
@jingxu97
Minor cleanup in snapshot test suite.
ae5da83
@jingxu97
Add pre provisioned snapshot tests
ced6ec7 
Make pre provisioned snapshots using CSI driver by
1. Take a dynamic snapshot with retain policy
2. Delete the dynamic snapshot and content
3. Create a preprovisioned snapshot with snapshotHandle

This commit adds a preprovisiond test pattern, all snapshots made using
create snapshot resource become prepv snapshots. All exisitng test cases
now run again with prepv snapshots.
@jingxu97
Combine two tests with overlap to reduce overall snapshot test suite …
e40ed24 
…time
@jingxu97
Remove snapshot class from prepv test because it is not needed.
f317947 
Prepv snapshots only need to specify driver.
@jingxu97
Quick commit
5295913
@jingxu97
Stack snapshot tests into one to reuse snapshot resource and reduce t…
21080cc 
…ime taken on prow.
@jingxu97
Remove custom hash function, generate a random UUID for snapshot and …
5ff7489 
…snapcontent name instead
@jingxu97
Move common portion of dynamic snapshot out of switch statement
036af74
@jingxu97
Ran hack/update-bazel.sh but discarded changes to root build file
141ba2c
@jingxu97
Combine switch case into one case
ac7d43b
@jingxu97
Fix testpattern check
bd9a4b8
@claudiubelu @jingxu97
tests: Refactors agnhost image pod usage in tests
7143608 
A previous commit created a few agnhost related functions that creates agnhost
pods / containers for general purposes.

Refactors tests to use those functions.
@jsafrane @jingxu97
Tolerate NotFound errors when deleting snapshots
f6b5a2d
@jsafrane @jingxu97
Log PodExec stdout + stderr
06c0faf 
e2e tests should log stdout / stderr of failed commands executed via
PodExec. "command terminated with exit code 1" is not really useful.
@jingxu97
Separate in-tree gcepd driver for windows
02b1bed 
Add a separate in-tree gcepd driver for windows cluster because it does
not support certain features as Linux driver.

Change-Id: I2fca86b3f32f17db7703c46a36944d9ee51f355f
@jingxu97
Modify storage snapshottable and disruptive test for Windows
a0cbddc 
Update snapshottable and disable disruptive test for Windows

Change-Id: I9d6beb25078c1941e405bf61545caae30326ddd1
@jingxu97
Update storage test suits for Windows
9f044d3 
Update storage test suits to enable some tests on Windows

Change-Id: I1f596bb9f7a0f41ae398aec43406ee5c753cdce3
@Jiawei0227 @jingxu97
Remove unnecessary snapshot ability check
7e1a736
@k8s-ci-robot
Copy link
Contributor

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

@jingxu97: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingxu97
To complete the pull request process, please assign liggitt after the PR has been reviewed.
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test labels Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2021
@jingxu97 jingxu97 changed the title Automated cherry pick of #93196: Minor cleanup in snapshot test suite. #94438: tests: Refactors agnhost image pod usage in tests #94653: Tolerate NotFound errors when deleting snapshots #95867: Log PodExec stdout + stderr #96294: Separate in-tree gcepd driver for windows #96330: Modify storage snapshottable and disruptive test for Windows #96360: Update storage test suits for Windows #96843: Remove unnecessary snapshot ability check Automated cherry pick of #93196: #94438: #94653: #95867: #96294: #96330: #96360: #96843: Feb 13, 2021
@jingxu97
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@jingxu97: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-ubuntu-gce-network-policies 7e1a736 link /test pull-kubernetes-e2e-ubuntu-gce-network-policies
pull-kubernetes-e2e-kind 7e1a736 link /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce-ubuntu-containerd 7e1a736 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-bazel-build 7e1a736 link /test pull-kubernetes-bazel-build
pull-kubernetes-e2e-gce-100-performance 7e1a736 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 7e1a736 link /test pull-kubernetes-typecheck
pull-kubernetes-bazel-test 7e1a736 link /test pull-kubernetes-bazel-test
pull-kubernetes-verify 7e1a736 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 16, 2021
@jingxu97 jingxu97 closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@liggitt liggitt Awaiting requested review from liggitt

Assignees
No one assigned
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jingxu97 @k8s-ci-robot @fedebongio @claudiubelu @jsafrane @Jiawei0227