Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: move filesystem resize code to kubernetes/mount-utils #99088

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Storage: move filesystem resize code to kubernetes/mount-utils #99088

merged 2 commits into from
Feb 23, 2021

Conversation

gavinfish
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move filesystem resize code to kubernetes/mount-utils so that it can be shared among with CSI drivers.

Which issue(s) this PR fixes:

Fixes #99039

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

@gavinfish: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Feb 15, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 15, 2021
@gavinfish
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

1 similar comment
@gavinfish
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@AndyXiangLi
Copy link
Contributor

Do we have plan to merge this?

@gavinfish
Copy link
Contributor Author

Do we have plan to merge this?

I will leave this to @jsafrane as I am just new to storage SIG.

/assign @jsafrane

jsafrane
jsafrane reviewed Feb 19, 2021
View reviewed changes
staging/src/k8s.io/mount-utils/resizefs_linux.go Outdated
}

// NewResizeFs returns new instance of resizer
func NewResizeFs(mounter *mount.SafeFormatAndMount) *ResizeFs {
func NewResizeFs(mounter *SafeFormatAndMount) *ResizeFs {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have utilexec.Interface as the only parameter? Because that's the only thing that ResizeFs needs. And smaller requirements in general make better interfaces.

You will need to refactor SafeFormatAndMount.GetDiskFormat - create a separate function getDiskFormat(exec utilexec.Interface, disk string) with all the logic, and have it called both by mounter.GetDiskFormat and ResizeFs.Resize().

Perhaps as a separate commit in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2021
@gavinfish
Copy link
Contributor Author

/retest

2 similar comments
@gavinfish
Copy link
Contributor Author

/retest

@gavinfish
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Member

Thanks a lot!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
@gavinfish
Copy link
Contributor Author

/assign @thockin

@thockin
Copy link
Member

thockin commented Feb 22, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinfish, jsafrane, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit ccf8a2e into kubernetes:master Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
@gavinfish gavinfish deleted the storage-resize branch February 23, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@dims dims Awaiting requested review from dims

Assignees

@jsafrane jsafrane

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Move filesystem resize code to kubernetes/mount-utils
5 participants
@gavinfish @k8s-ci-robot @AndyXiangLi @jsafrane @thockin