Use the correct volum handle format for GCE regional PD.

[TeweiLuo]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix bug in gcd_pd PV translation to make sure migration works for regional disks.

Which issue(s) this PR fixes:

Fixes #85623

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @TeweiLuo!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @TeweiLuo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jiawei0227]

/ok-to-test
/lgtm

[Jiawei0227]

/sig storage
/triage accepted

[Jiawei0227]

@msau42 can you help to approve this?

[Jiawei0227]

/assign @msau42

[msau42]

do we have a unit test for this?

[TeweiLuo]

The only test we have that covers PV translation is

kubernetes/staging/src/k8s.io/csi-translation-lib/translate_test.go

Line 47 in e16c6cc

func TestTranslationStability(t *testing.T) {

. Since translation from CSI to in-tree doesn't rely on the volume handle, this bug doesn't affect the test. We could add a PD specific test to cover TranslateInTreePVToCSI().

[msau42]

Yeah I think a unit test to cover this case would be good

[TeweiLuo]

Ack - will add a test case.

[TeweiLuo]

Update: since RePD migration is hard to test with OSS e2e infra, we'll test internally in GKE and then sync the status there.

[Jiawei0227]

I think what Michelle means is we can add a unit test in https://github.com/kubernetes/kubernetes/blob/e16c6cc3483989899961c623518a1150e9078495/staging/src/k8s.io/csi-translation-lib/plugins/gce_pd_test.go to test if the volID being generated is correct when TranslateInTreePVToCSI

[Jiawei0227]

/lgtm

[msau42]

/lgtm
/approve

Thanks!

/milestone v1.21

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, TeweiLuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/csi-translation-lib/OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TeweiLuo]

/test pull-kubernetes-node-e2e