-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #90980: Avoid using socket for hints #99276
Automated cherry pick of #90980: Avoid using socket for hints #99276
Conversation
Sockets don't affect performance as NUMA node does, since NUMA node has dedicated memory controller, but socket it's physical extension point. Socket it's only cpu specific thing and it's strange to merge bitmask of deviceplugin's and cpu manager, when cpu manager takes into account socket. Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
This patch removes GetNUMANodeInfo, cadvisor.MachineInfo will be used instead of it. GetNUMANodeInfo was introduced due to difference of meaning of MachineInfo.Topology. On the arm it was NUMA nodes, but on the x86 it represents sockets (since reading from /proc/cpuinfo). Now it unified and MachineInfo.Topology represents NUMA node. Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
7a37787
to
33547e4
Compare
Hi @iwankgb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
@iwankgb Please add a release note. /priority important-soon |
/assign @klueska |
/retest |
Did the change I reviewed for 1.20 apply cleanly, or were there any merge conflicts that needed to be resolved in the backport? |
Thanks for confirming /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iwankgb, klueska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kind |
2 similar comments
/test pull-kubernetes-e2e-kind |
/test pull-kubernetes-e2e-kind |
/test pull-kubernetes-node-e2e |
/retest Review the full test history for this PR. Silence the bot with an |
/test pull-kubernetes-node-e2e |
1 similar comment
/test pull-kubernetes-node-e2e |
/retest |
1 similar comment
/retest |
Cherry pick of #90980 on release-1.19.
#90980: Avoid using socket for hints
For details on the cherry pick process, see the cherry pick requests page.