-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pkg/kubelet/lifecycle,oom
to structured logging
#99479
Migrate pkg/kubelet/lifecycle,oom
to structured logging
#99479
Conversation
Hi @mengjiao-liu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
298021d
to
4fcf9e6
Compare
/priority important-soon |
/sig instrumentation |
/ok-to-test |
84623bb
to
94fd6c0
Compare
/retest |
1 similar comment
/retest |
/triage accepted |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm cancel
/cc @serathius
@@ -110,7 +110,7 @@ func (w *predicateAdmitHandler) Admit(attrs *PodAdmitAttributes) PodAdmitResult | |||
fit = len(reasons) == 0 && err == nil | |||
if err != nil { | |||
message := fmt.Sprintf("Unexpected error while attempting to recover from admission failure: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message := fmt.Sprintf("Unexpected error while attempting to recover from admission failure: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Sorry for the back and forth, I think this is my first full review of this CL! |
9735ef7
to
acb397f
Compare
/test pull-kubernetes-unit |
1 similar comment
/test pull-kubernetes-unit |
Co-authored-by: Elana Hashman <ehashman@users.noreply.github.com>
acb397f
to
e557f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes made (excluding message deletion which is used later in file), author also updated all logs in selected files, changes look good.
/lgtm
/milestone v1.21 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mengjiao-liu, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
For Structured Logging Migration: kubernetes/enhancements#1602
Migrate
pkg/kubelet/lifecycle,oom
to structured loggingWhich issue(s) this PR fixes:
Ref #98976
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: