Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/lifecycle,oom to structured logging #99479

Merged

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Feb 26, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

For Structured Logging Migration: kubernetes/enhancements#1602
Migrate pkg/kubelet/lifecycle,oom to structured logging

Which issue(s) this PR fixes:

Ref #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/S cncf-cla: yes do-not-merge/needs-sig needs-triage labels Feb 26, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 26, 2021

Hi @mengjiao-liu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test needs-priority labels Feb 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and sjenning Feb 26, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node and removed do-not-merge/needs-sig labels Feb 26, 2021
@mengjiao-liu mengjiao-liu force-pushed the migrate_to_structured_logs branch from 298021d to 4fcf9e6 Compare Feb 26, 2021
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu mengjiao-liu commented Feb 26, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon and removed needs-priority labels Feb 26, 2021
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu mengjiao-liu commented Feb 26, 2021

/sig instrumentation
/sig node

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation label Feb 26, 2021
@pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 26, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Feb 26, 2021
@mengjiao-liu mengjiao-liu force-pushed the migrate_to_structured_logs branch from 84623bb to 94fd6c0 Compare Feb 26, 2021
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu mengjiao-liu commented Feb 26, 2021

/retest

1 similar comment
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu mengjiao-liu commented Feb 26, 2021

/retest

@adisky adisky added this to Triage in SIG Node PR Triage Feb 26, 2021
@adisky
Copy link
Contributor

@adisky adisky commented Feb 26, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted and removed needs-triage labels Feb 26, 2021
@yuzhiquan
Copy link
Member

@yuzhiquan yuzhiquan commented Mar 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 6, 2021
Copy link
Member

@ehashman ehashman left a comment

/lgtm cancel
/cc @serathius

pkg/kubelet/lifecycle/handlers.go Outdated Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Outdated Show resolved Hide resolved
@@ -110,7 +110,7 @@ func (w *predicateAdmitHandler) Admit(attrs *PodAdmitAttributes) PodAdmitResult
fit = len(reasons) == 0 && err == nil
if err != nil {
message := fmt.Sprintf("Unexpected error while attempting to recover from admission failure: %v", err)
Copy link
Member

@ehashman ehashman Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message := fmt.Sprintf("Unexpected error while attempting to recover from admission failure: %v", err)

Copy link
Member Author

@mengjiao-liu mengjiao-liu Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

pkg/kubelet/lifecycle/predicate.go Outdated Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Outdated Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Outdated Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Outdated Show resolved Hide resolved
pkg/kubelet/lifecycle/predicate.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from serathius Mar 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 8, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 8, 2021

Sorry for the back and forth, I think this is my first full review of this CL!

@mengjiao-liu mengjiao-liu force-pushed the migrate_to_structured_logs branch from 9735ef7 to acb397f Compare Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Mar 11, 2021
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu mengjiao-liu commented Mar 11, 2021

/test pull-kubernetes-unit

1 similar comment
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu mengjiao-liu commented Mar 11, 2021

/test pull-kubernetes-unit

Co-authored-by: Elana Hashman <ehashman@users.noreply.github.com>
@mengjiao-liu mengjiao-liu force-pushed the migrate_to_structured_logs branch from acb397f to e557f61 Compare Mar 11, 2021
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

All requested changes made (excluding message deletion which is used later in file), author also updated all logs in selected files, changes look good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 11, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 11, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 11, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Mar 11, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengjiao-liu, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit bebb932 into kubernetes:master Mar 12, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/instrumentation sig/node size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

8 participants