Configured resource-only container /docker-daemon with 70% of node me… #9961
Conversation
…mory capacity. This is a workaround to docker memory leakage issue.
|
ok to test |
|
Do we have a docker issue # for the leak? |
|
GCE e2e build/test passed for commit ca95eb7. |
|
Docker issue is moby/moby#9139, while filed against 1.3.0, and docker claim it is fixed in 1.7.0. |
| } else { | ||
| capacity = CapacityFromMachineInfo(info) | ||
| } | ||
| memoryLimit := (int64(capacity.Memory().Value() * DockerMemoryLimitThresholdPercent / 100)) |
There was a problem hiding this comment.
Can we sanity check for a lower threshold in case cAdvisor is returning 0 or really low values. Make it at least 100M?
|
If cadvisor return 0 which means failed to get node memory capacity, libcontainer will ignore that value, because kernel cgroup will reject value 0 to write to memory.limit_in_bytes anyway. But you are right, cadvisor might return a wrong value which is too small. I will add a check. |
at least 150Mi at least.
|
Add a sanity check, and make sure it at least 150M for now. PTAL? |
|
ok to test |
|
GCE e2e build/test passed for commit 32d5f46. |
|
GCE e2e build/test passed for commit 32d5f46. |
|
LGTM |
rjnagal
added
the
lgtm
Configured resource-only container /docker-daemon with 70% of node me…
…mory capacity. This is a workaround to docker memory leakage issue.
Without this pr, /docker-daemon is configured with unlimited memory:
With this, it has 70% of node memory capacity:
Fix #9881
cc/ @rjnagal