Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube stop - correct the number of stopped nodes #11740

Closed
igorradovanov opened this issue Jun 22, 2021 · 2 comments · Fixed by #11752
Closed

Minikube stop - correct the number of stopped nodes #11740

igorradovanov opened this issue Jun 22, 2021 · 2 comments · Fixed by #11752
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/improvement Categorizes issue or PR as related to improving upon a current feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@igorradovanov
Copy link

Steps to reproduce the issue:

  1. minikube start
  2. minikube stop

When there is a single node stopped, the plural word "nodes" is used instead of singular which can be confusing. I find this particularly to be a simple fix within the next file on the line 123:

out.Step(style.Stopped, `{{.count}} nodes stopped.`, out.V{"count": stoppedNodes})

Screenshot:

image

Full output of minikube logs command:

No applicable, UI bug.

Full output of failed command:

No applicable, UI bug.

@ilya-zuyev ilya-zuyev added kind/bug Categorizes issue or PR as related to a bug. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 22, 2021
@medyagh
Copy link
Member

medyagh commented Jun 30, 2021

thank u for notiicing this

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/improvement Categorizes issue or PR as related to improving upon a current feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants