Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri: Add API for saving an image to a local path #11128

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Apr 18, 2021

This function SaveImage is the opposite of LoadImage,
useful for saving built images to the cache directory.

This is an alternative to using the push functionality,
which requires a registry (similar to the pull function).

For #11130

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 18, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 20, 2021
@afbjorklund afbjorklund changed the title WIP: Add API for saving an image to a local path Add API for saving an image to a local path Apr 25, 2021
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 25, 2021
pkg/minikube/cruntime/cruntime.go Outdated Show resolved Hide resolved
This function SaveImage is the opposite of LoadImage,
useful for saving built images to the cache directory.

This is an alternative to using the push functionality,
which requires a registry similar to the pull function.
@medyagh
Copy link
Member

medyagh commented Apr 27, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 27, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11128) |
+----------------+----------+---------------------+
| minikube start | 50.5s    | 49.5s               |
| enable ingress | 35.2s    | 35.0s               |
+----------------+----------+---------------------+

Times for minikube start: 53.2s 47.1s 49.2s 52.1s 51.0s
Times for minikube (PR 11128) start: 51.3s 46.1s 53.8s 47.2s 49.2s

Times for minikube ingress: 36.4s 35.3s 34.3s 36.4s 33.8s
Times for minikube (PR 11128) ingress: 33.8s 34.3s 35.2s 34.3s 37.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11128) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.1s               |
| enable ingress | 30.0s    | 29.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.0s 28.5s 28.5s 29.0s 33.0s
Times for minikube (PR 11128) ingress: 29.5s 32.0s 28.5s 29.0s 29.5s

Times for minikube start: 22.2s 21.2s 22.7s 21.4s 21.4s
Times for minikube (PR 11128) start: 20.7s 21.7s 21.0s 20.7s 21.4s

docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@medyagh
Copy link
Member

medyagh commented Apr 29, 2021

Looks good to me

@medyagh medyagh merged commit 3de6dc0 into kubernetes:master Apr 29, 2021
@medyagh medyagh changed the title Add API for saving an image to a local path cri: Add API for saving an image to a local path Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund afbjorklund mentioned this pull request Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants