Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InAccel FPGA Operator addon #12995

Merged
merged 1 commit into from Jun 7, 2022
Merged

InAccel FPGA Operator addon #12995

merged 1 commit into from Jun 7, 2022

Conversation

eliaskoromilas
Copy link
Contributor

@eliaskoromilas eliaskoromilas commented Nov 20, 2021 •
edited

Simplifying FPGA management in Minikube

asciicast

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 20, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @eliaskoromilas!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @eliaskoromilas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@eliaskoromilas
Copy link
Contributor Author

/assign @spowelljr

@spowelljr
Copy link
Member

Hi @eliaskoromilas, would it be possible to add an integration test to test/integration/addons_test.go?

@eliaskoromilas
Copy link
Contributor Author

@spowelljr Sure, but it's going to be platform specific (e.g. AWS F1 instances).

@eliaskoromilas
Copy link
Contributor Author

rebase

@eliaskoromilas
Copy link
Contributor Author

Amazon EC2 / f1.2xlarge:

$ env TEST_ARGS="-minikube-start-args=--driver=none -test.run TestAddons" make integration
go test -ldflags="-X k8s.io/minikube/pkg/version.version=v1.24.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.24.0 -X k8s.io/minikube/pkg/version.gitCommitID="8379487c018053849e1d95461e49fe953ac433c8" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -v -test.timeout=90m ./test/integration --tags="integration " -minikube-start-args=--driver=none -test.run TestAddons 2>&1 | tee "./out/testout_8379487c0.txt"
Found 8 cores, limiting parallelism with --test.parallel=4
=== RUN   TestAddons
=== RUN   TestAddons/Setup
    addons_test.go:78: (dbg) Run:  out/minikube start -p minikube --wait=true --memory=4000 --alsologtostderr --addons=registry --addons=metrics-server --addons=olm --addons=volumesnapshots --addons=csi-hostpath-driver --addons=gcp-auth --driver=none --addons=inaccel --addons=helm-tiller
    addons_test.go:78: (dbg) Done: out/minikube start -p minikube --wait=true --memory=4000 --alsologtostderr --addons=registry --addons=metrics-server --addons=olm --addons=volumesnapshots --addons=csi-hostpath-driver --addons=gcp-auth --driver=none --addons=inaccel --addons=helm-tiller: (2m5.454064543s)
=== RUN   TestAddons/parallel
=== RUN   TestAddons/parallel/Registry
    addons_test.go:284: registry stabilized in 13.800826ms
    addons_test.go:286: (dbg) TestAddons/parallel/Registry: waiting 6m0s for pods matching "actual-registry=true" in namespace "kube-system" ...
    helpers_test.go:343: "registry-sgn6h" [88a65e03-106f-4aed-8532-952269d7a639] Running
    addons_test.go:286: (dbg) TestAddons/parallel/Registry: actual-registry=true healthy within 5.014616796s
    addons_test.go:289: (dbg) TestAddons/parallel/Registry: waiting 10m0s for pods matching "registry-proxy=true" in namespace "kube-system" ...
    helpers_test.go:343: "registry-proxy-x57jp" [4b47b890-3755-41d9-8239-52fa9ef0cf37] Running
    addons_test.go:289: (dbg) TestAddons/parallel/Registry: registry-proxy=true healthy within 5.009350156s
    addons_test.go:294: (dbg) Run:  kubectl --context minikube delete po -l run=registry-test --now
    addons_test.go:299: (dbg) Run:  kubectl --context minikube run --rm registry-test --restart=Never --image=busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local"
    addons_test.go:299: (dbg) Done: kubectl --context minikube run --rm registry-test --restart=Never --image=busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local": (1.945409795s)
    addons_test.go:313: (dbg) Run:  out/minikube -p minikube ip
2021/11/30 15:29:49 [DEBUG] GET http://172.31.85.102:5000
    addons_test.go:342: (dbg) Run:  out/minikube -p minikube addons disable registry --alsologtostderr -v=1
=== RUN   TestAddons/parallel/Ingress
    addons_test.go:155: skipping: ingress not supported
=== RUN   TestAddons/parallel/MetricsServer
    addons_test.go:361: metrics-server stabilized in 15.11042ms
    addons_test.go:363: (dbg) TestAddons/parallel/MetricsServer: waiting 6m0s for pods matching "k8s-app=metrics-server" in namespace "kube-system" ...
    helpers_test.go:343: "metrics-server-77c99ccb96-b7cnf" [3a176bf3-b482-47d0-a74b-c2b1b39f5039] Running
    addons_test.go:363: (dbg) TestAddons/parallel/MetricsServer: k8s-app=metrics-server healthy within 5.014181846s
    addons_test.go:369: (dbg) Run:  kubectl --context minikube top pods -n kube-system
    addons_test.go:386: (dbg) Run:  out/minikube -p minikube addons disable metrics-server --alsologtostderr -v=1
=== RUN   TestAddons/parallel/HelmTiller
    addons_test.go:410: tiller-deploy stabilized in 2.740345ms
    addons_test.go:412: (dbg) TestAddons/parallel/HelmTiller: waiting 6m0s for pods matching "app=helm" in namespace "kube-system" ...
    helpers_test.go:343: "tiller-deploy-64b546c44b-m2r7b" [8d4fbbbf-eb56-4b3d-bfa6-37b1a8a0f49b] Running
    addons_test.go:412: (dbg) TestAddons/parallel/HelmTiller: app=helm healthy within 5.009216954s
    addons_test.go:427: (dbg) Run:  kubectl --context minikube run --rm helm-test --restart=Never --image=alpine/helm:2.16.3 -it --namespace=kube-system -- version
    addons_test.go:427: (dbg) Done: kubectl --context minikube run --rm helm-test --restart=Never --image=alpine/helm:2.16.3 -it --namespace=kube-system -- version: (3.415687587s)
    addons_test.go:444: (dbg) Run:  out/minikube -p minikube addons disable helm-tiller --alsologtostderr -v=1
=== RUN   TestAddons/parallel/Olm
    addons_test.go:456: (dbg) Run:  kubectl --context minikube wait --for=condition=ready --namespace=olm pod --selector=app=catalog-operator --timeout=90s
    addons_test.go:459: catalog-operator stabilized in 95.809477ms
    addons_test.go:461: (dbg) Run:  kubectl --context minikube wait --for=condition=ready --namespace=olm pod --selector=app=olm-operator --timeout=90s
    addons_test.go:464: olm-operator stabilized in 176.431089ms
    addons_test.go:466: (dbg) Run:  kubectl --context minikube wait --for=condition=ready --namespace=olm pod --selector=app=packageserver --timeout=90s
    addons_test.go:469: packageserver stabilized in 271.157326ms
    addons_test.go:471: (dbg) Run:  kubectl --context minikube wait --for=condition=ready --namespace=olm pod --selector=olm.catalogSource=operatorhubio-catalog --timeout=90s
    addons_test.go:474: operatorhubio-catalog stabilized in 362.666346ms
    addons_test.go:477: (dbg) Run:  kubectl --context minikube create -f testdata/etcd.yaml
    addons_test.go:477: (dbg) Done: kubectl --context minikube create -f testdata/etcd.yaml: (1.247706211s)
    addons_test.go:484: (dbg) Run:  kubectl --context minikube get csv -n my-etcd
    addons_test.go:489: kubectl --context minikube get csv -n my-etcd: unexpected stderr: No resources found in my-etcd namespace.
    addons_test.go:484: (dbg) Run:  kubectl --context minikube get csv -n my-etcd
    addons_test.go:489: kubectl --context minikube get csv -n my-etcd: unexpected stderr: No resources found in my-etcd namespace.
    addons_test.go:484: (dbg) Run:  kubectl --context minikube get csv -n my-etcd
    addons_test.go:489: kubectl --context minikube get csv -n my-etcd: unexpected stderr: No resources found in my-etcd namespace.
    addons_test.go:484: (dbg) Run:  kubectl --context minikube get csv -n my-etcd
    addons_test.go:484: (dbg) Run:  kubectl --context minikube get csv -n my-etcd
=== RUN   TestAddons/parallel/CSI
    addons_test.go:515: csi-hostpath-driver pods stabilized in 8.354087ms
    addons_test.go:518: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pvc.yaml
    addons_test.go:518: (dbg) Done: kubectl --context minikube create -f testdata/csi-hostpath-driver/pvc.yaml: (1.123747133s)
    addons_test.go:523: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pvc "hpvc" in namespace "default" ...
    helpers_test.go:393: (dbg) Run:  kubectl --context minikube get pvc hpvc -o jsonpath={.status.phase} -n default
    addons_test.go:528: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pv-pod.yaml
    addons_test.go:533: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pods matching "app=task-pv-pod" in namespace "default" ...
    helpers_test.go:343: "task-pv-pod" [0c1e4041-4f56-4f3a-8e28-3a5a41ae6efb] Pending
    helpers_test.go:343: "task-pv-pod" [0c1e4041-4f56-4f3a-8e28-3a5a41ae6efb] Pending / Ready:ContainersNotReady (containers with unready status: [task-pv-container]) / ContainersReady:ContainersNotReady (containers with unready status: [task-pv-container])
    helpers_test.go:343: "task-pv-pod" [0c1e4041-4f56-4f3a-8e28-3a5a41ae6efb] Running
    addons_test.go:533: (dbg) TestAddons/parallel/CSI: app=task-pv-pod healthy within 19.006914254s
    addons_test.go:538: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/snapshot.yaml
    addons_test.go:543: (dbg) TestAddons/parallel/CSI: waiting 6m0s for volume snapshot "new-snapshot-demo" in namespace "default" ...
    helpers_test.go:418: (dbg) Run:  kubectl --context minikube get volumesnapshot new-snapshot-demo -o jsonpath={.status.readyToUse} -n default
    helpers_test.go:418: (dbg) Run:  kubectl --context minikube get volumesnapshot new-snapshot-demo -o jsonpath={.status.readyToUse} -n default
    addons_test.go:548: (dbg) Run:  kubectl --context minikube delete pod task-pv-pod
    addons_test.go:554: (dbg) Run:  kubectl --context minikube delete pvc hpvc
    addons_test.go:560: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pvc-restore.yaml
    addons_test.go:565: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pvc "hpvc-restore" in namespace "default" ...
    helpers_test.go:393: (dbg) Run:  kubectl --context minikube get pvc hpvc-restore -o jsonpath={.status.phase} -n default
    addons_test.go:570: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pv-pod-restore.yaml
    addons_test.go:575: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pods matching "app=task-pv-pod-restore" in namespace "default" ...
    helpers_test.go:343: "task-pv-pod-restore" [ed2b205d-0ed9-44df-b46c-42e0b36c5078] Pending
    helpers_test.go:343: "task-pv-pod-restore" [ed2b205d-0ed9-44df-b46c-42e0b36c5078] Pending / Ready:ContainersNotReady (containers with unready status: [task-pv-container]) / ContainersReady:ContainersNotReady (containers with unready status: [task-pv-container])
    helpers_test.go:343: "task-pv-pod-restore" [ed2b205d-0ed9-44df-b46c-42e0b36c5078] Running
    addons_test.go:575: (dbg) TestAddons/parallel/CSI: app=task-pv-pod-restore healthy within 15.007180446s
    addons_test.go:580: (dbg) Run:  kubectl --context minikube delete pod task-pv-pod-restore
    addons_test.go:580: (dbg) Done: kubectl --context minikube delete pod task-pv-pod-restore: (1.569928172s)
    addons_test.go:584: (dbg) Run:  kubectl --context minikube delete pvc hpvc-restore
    addons_test.go:588: (dbg) Run:  kubectl --context minikube delete volumesnapshot new-snapshot-demo
    addons_test.go:592: (dbg) Run:  out/minikube -p minikube addons disable csi-hostpath-driver --alsologtostderr -v=1
    addons_test.go:592: (dbg) Done: out/minikube -p minikube addons disable csi-hostpath-driver --alsologtostderr -v=1: (6.666361604s)
    addons_test.go:596: (dbg) Run:  out/minikube -p minikube addons disable volumesnapshots --alsologtostderr -v=1
=== RUN   TestAddons/parallel/InAccel
    addons_test.go:729: (dbg) Run:  kubectl --context minikube create --filename testdata/inaccel.yaml
    addons_test.go:734: (dbg) Run:  kubectl --context minikube wait --for condition=ready --timeout -1s pod/inaccel-vadd
    addons_test.go:734: (dbg) Done: kubectl --context minikube wait --for condition=ready --timeout -1s pod/inaccel-vadd: (3m5.383374573s)
    addons_test.go:738: (dbg) Run:  kubectl --context minikube logs --follow pod/inaccel-vadd
    addons_test.go:738: (dbg) Done: kubectl --context minikube logs --follow pod/inaccel-vadd: (6.179247542s)
    addons_test.go:747: (dbg) Run:  kubectl --context minikube delete pod/inaccel-vadd
=== RUN   TestAddons/serial
=== RUN   TestAddons/serial/GCPAuth
    addons_test.go:607: (dbg) Run:  kubectl --context minikube create -f testdata/busybox.yaml
    addons_test.go:607: (dbg) Done: kubectl --context minikube create -f testdata/busybox.yaml: (1.078477636s)
    addons_test.go:613: (dbg) TestAddons/serial/GCPAuth: waiting 8m0s for pods matching "integration-test=busybox" in namespace "default" ...
    helpers_test.go:343: "busybox" [7fc707ed-47b5-493d-9e18-b8711b2c33b4] Pending / Ready:ContainersNotReady (containers with unready status: [busybox]) / ContainersReady:ContainersNotReady (containers with unready status: [busybox])
    helpers_test.go:343: "busybox" [7fc707ed-47b5-493d-9e18-b8711b2c33b4] Running
    addons_test.go:613: (dbg) TestAddons/serial/GCPAuth: integration-test=busybox healthy within 7.015933761s
    addons_test.go:619: (dbg) Run:  kubectl --context minikube exec busybox -- /bin/sh -c "printenv GOOGLE_APPLICATION_CREDENTIALS"
    addons_test.go:632: (dbg) Run:  kubectl --context minikube exec busybox -- /bin/sh -c "cat /google-app-creds.json"
    addons_test.go:656: (dbg) Run:  kubectl --context minikube exec busybox -- /bin/sh -c "printenv GOOGLE_CLOUD_PROJECT"
    addons_test.go:669: (dbg) Run:  out/minikube -p minikube addons disable gcp-auth --alsologtostderr -v=1
    addons_test.go:669: (dbg) Done: out/minikube -p minikube addons disable gcp-auth --alsologtostderr -v=1: (6.386943971s)
=== RUN   TestAddons/StoppedEnableDisable
    addons_test.go:136: (dbg) Run:  out/minikube stop -p minikube
    addons_test.go:136: (dbg) Done: out/minikube stop -p minikube: (10.653090312s)
    addons_test.go:140: (dbg) Run:  out/minikube addons enable dashboard -p minikube
    addons_test.go:144: (dbg) Run:  out/minikube addons disable dashboard -p minikube
=== CONT  TestAddons
    helpers_test.go:176: Cleaning up "minikube" profile ...
    helpers_test.go:179: (dbg) Run:  out/minikube delete -p minikube
    helpers_test.go:179: (dbg) Done: out/minikube delete -p minikube: (4.788245892s)
--- PASS: TestAddons (444.74s)
    --- PASS: TestAddons/Setup (125.46s)
    --- PASS: TestAddons/parallel (288.39s)
        --- PASS: TestAddons/parallel/Registry (12.75s)
        --- SKIP: TestAddons/parallel/Ingress (0.00s)
        --- PASS: TestAddons/parallel/MetricsServer (5.45s)
        --- PASS: TestAddons/parallel/HelmTiller (8.78s)
        --- PASS: TestAddons/parallel/Olm (21.40s)
        --- PASS: TestAddons/parallel/CSI (47.22s)
        --- PASS: TestAddons/parallel/InAccel (192.78s)
    --- PASS: TestAddons/serial (15.19s)
        --- PASS: TestAddons/serial/GCPAuth (15.19s)
    --- PASS: TestAddons/StoppedEnableDisable (10.92s)
PASS
Tests completed in 7m24.745081222s (result code 0)
ok  	k8s.io/minikube/test/integration	444.847s

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 16, 2021
@eliaskoromilas
Copy link
Contributor Author

@spowelljr PTAL

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2022
@eliaskoromilas
Copy link
Contributor Author

/remove-lifecycle stale

@spowelljr An integration test is added. Could you please take another look?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2022
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 51.8s    | 51.5s               |
| enable ingress | 27.9s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 53.2s 51.9s 51.6s 49.9s 52.6s
Times for minikube (PR 12995) start: 50.4s 50.8s 52.8s 51.0s 52.3s

Times for minikube ingress: 28.6s 28.6s 26.1s 30.1s 26.1s
Times for minikube (PR 12995) ingress: 28.6s 28.6s 28.6s 29.0s 30.1s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@eliaskoromilas
Copy link
Contributor Author

rebase

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 1.21 (chart)
Hyperkit_macOS TestMultiNode/serial/AddNode (gopogh) 1.21 (chart)
Hyperkit_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 1.21 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 1.21 (chart)
Hyperkit_macOS TestMultiNode/serial/StartAfterStop (gopogh) 1.21 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh) 3.33 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Stop (gopogh) 4.40 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 5.43 (chart)
Hyperkit_macOS TestFunctional/serial/ComponentHealth (gopogh) 6.67 (chart)
Docker_Windows TestNetworkPlugins/group/calico/NetCatPod (gopogh) 7.41 (chart)
Docker_Windows TestPause/serial/Start (gopogh) 9.93 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.55 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 14.57 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 30.69 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 31.65 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 33.33 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 38.04 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 48.51 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 52.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 53.97 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 54.93 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 55.45 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 57.97 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 59.00 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 60.14 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 61.39 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 66.67 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 71.43 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 77.85 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 52.4s    | 50.8s               |
| enable ingress | 29.6s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube start: 53.9s 52.1s 55.0s 50.1s 50.8s
Times for minikube (PR 12995) start: 50.6s 51.4s 50.8s 51.0s 50.4s

Times for minikube ingress: 29.1s 30.0s 30.6s 29.1s 29.0s
Times for minikube (PR 12995) ingress: 29.0s 26.0s 29.1s 30.6s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 25.7s    | 24.4s               |
| enable ingress | 22.4s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 30.0s 25.5s 24.1s 24.2s 24.4s
Times for minikube (PR 12995) start: 24.2s 24.2s 24.9s 24.0s 24.7s

Times for minikube ingress: 22.9s 22.4s 20.9s 23.0s 23.0s
Times for minikube (PR 12995) ingress: 22.4s 21.9s 22.4s 23.4s 24.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 39.3s    | 42.8s               |
| enable ingress | 24.5s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube start: 29.6s 44.4s 43.3s 39.6s 39.6s
Times for minikube (PR 12995) start: 39.6s 43.9s 43.8s 43.8s 43.1s

Times for minikube ingress: 32.4s 17.9s 27.9s 22.4s 21.9s
Times for minikube (PR 12995) ingress: 22.4s 17.9s 19.4s 27.9s 17.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestNetworkPlugins/group/auto/DNS (gopogh) 0.00 (chart)
KVM_Linux TestPause/serial/Pause (gopogh) 1.70 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 3.80 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 14.02 (chart)
Docker_Windows TestNetworkPlugins/group/auto/DNS (gopogh) 19.57 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 21.09 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 23.81 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 31.65 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 37.63 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 43.40 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 44.83 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 48.55 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 51.27 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 52.48 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 53.54 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 54.73 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 55.88 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 61.39 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 66.67 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 70.83 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 71.43 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 73.27 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 77.85 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 80.31 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 82.58 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 83.45 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 86.08 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 86.71 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 87.97 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 95.39 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 52.0s    | 52.6s               |
| enable ingress | 29.3s    | 29.6s               |
+----------------+----------+---------------------+

Times for minikube start: 52.5s 52.1s 51.6s 51.7s 52.3s
Times for minikube (PR 12995) start: 56.7s 51.2s 52.2s 51.7s 51.0s

Times for minikube ingress: 29.2s 28.1s 29.7s 30.1s 29.6s
Times for minikube (PR 12995) ingress: 29.6s 28.6s 29.1s 30.1s 30.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 26.1s    | 25.0s               |
| enable ingress | 22.5s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 28.5s 25.6s 25.4s 26.3s 24.6s
Times for minikube (PR 12995) start: 24.9s 24.8s 24.7s 25.0s 25.6s

Times for minikube ingress: 21.9s 21.9s 22.9s 24.4s 21.4s
Times for minikube (PR 12995) ingress: 23.4s 20.9s 22.0s 22.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 39.6s    | 39.7s               |
| enable ingress | 20.7s    | 20.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12995) start: 39.4s 40.6s 32.6s 40.7s 45.1s
Times for minikube start: 29.4s 40.1s 39.9s 44.5s 44.2s

Times for minikube ingress: 21.9s 22.4s 22.4s 18.0s 19.0s
Times for minikube (PR 12995) ingress: 22.4s 21.9s 18.9s 22.4s 18.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 6.04 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 22.92 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 24.00 (chart)
Docker_Windows TestNetworkPlugins/group/auto/DNS (gopogh) 25.74 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 27.03 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 31.17 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 36.84 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 41.67 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 46.51 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 48.12 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 52.63 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 53.45 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 56.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 57.14 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 63.16 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 71.79 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 74.07 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 74.42 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 76.38 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 78.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 79.39 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 79.61 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 79.85 (chart)
Docker_Windows TestNoKubernetes/serial/Start (gopogh) 84.07 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 84.21 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 84.87 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 85.53 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 99.33 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 99.36 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 12995) |
+-------------------+----------+---------------------+
| minikube start    | 51.4s    | 51.4s               |
| ⚠️  enable ingress | 28.2s    | 33.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 51.9s 50.8s 49.9s 50.6s 53.9s
Times for minikube (PR 12995) start: 52.9s 50.5s 51.7s 50.7s 51.4s

Times for minikube ingress: 29.1s 29.1s 29.0s 28.1s 25.6s
Times for minikube (PR 12995) ingress: 30.0s 31.5s 28.6s 30.1s 47.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 25.2s    | 24.3s               |
| enable ingress | 21.8s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube start: 28.6s 23.4s 24.1s 24.8s 25.2s
Times for minikube (PR 12995) start: 24.4s 24.0s 24.4s 25.2s 23.7s

Times for minikube ingress: 21.9s 22.4s 20.4s 21.4s 22.9s
Times for minikube (PR 12995) ingress: 22.4s 23.5s 25.9s 23.4s 22.5s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 12995) |
+-------------------+----------+---------------------+
| minikube start    | 35.1s    | 30.4s               |
| ⚠️  enable ingress | 20.7s    | 26.1s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 31.3s 28.6s 43.9s 39.5s 32.3s
Times for minikube (PR 12995) start: 28.1s 31.5s 28.8s 31.4s 32.3s

Times for minikube ingress: 23.0s 22.4s 17.9s 21.4s 18.9s
Times for minikube (PR 12995) ingress: 52.4s 18.9s 22.4s 18.9s 17.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestKubernetesUpgrade (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 1.75 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 8.85 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 9.73 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 11.11 (chart)
Docker_Linux_containerd TestAddons/parallel/Registry (gopogh) 17.44 (chart)
Docker_Linux_containerd TestOffline (gopogh) 27.43 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 27.43 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 35.90 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 36.71 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 37.17 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 37.17 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 37.17 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 37.17 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 37.18 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 38.05 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 38.75 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 42.31 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 42.31 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 43.04 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 43.75 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal
Copy link
Collaborator

Hey, it seems like one of our unit tests is failing. Could you take a look and fix it? Once that's fixed and the tests are rerun, we can go ahead and get this merged.

@eliaskoromilas
Copy link
Contributor Author

eliaskoromilas commented May 25, 2022 •
edited

Hey, it seems like one of our unit tests is failing. Could you take a look and fix it? Once that's fixed and the tests are rerun, we can go ahead and get this merged.

@sharifelgamal In TestAddonsList/NonExistingClusterJSON there is a temp buffer that needs to be large enough to fit the JSON addons list. I just allocated 13 more bytes for the new entry ("inaccel":{},), it should be fine now (but we could consider an one time fix, check also 67f748f).

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 50.9s               |
| enable ingress | 29.0s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 52.3s 50.2s 51.2s 50.7s 51.2s
Times for minikube (PR 12995) start: 51.2s 51.5s 51.2s 50.2s 50.5s

Times for minikube ingress: 30.1s 25.6s 29.6s 30.1s 29.6s
Times for minikube (PR 12995) ingress: 29.1s 25.0s 25.6s 29.1s 25.6s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.6/preload-exists (gopogh) n/a
Docker_Cloud_Shell TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/NetCatPod (gopogh) 0.00 (chart)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_macOS TestAddons/Setup (gopogh) 0.96 (chart)
Docker_macOS TestBinaryMirror (gopogh) 0.96 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 0.96 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 1.92 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 10.20 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 11.11 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 23.46 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 29.49 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 29.49 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 30.77 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 34.15 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 35.90 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 36.71 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 37.18 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 38.75 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 45.65 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 46.74 (chart)
Docker_Windows TestPause/serial/Start (gopogh) 51.43 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 54.29 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 55.13 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 56.25 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 56.25 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 56.79 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 57.89 (chart)
Docker_Windows TestNoKubernetes/serial/Start (gopogh) 58.25 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@eliaskoromilas
Add inaccel/fpga-operator addon
6364518 
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
@eliaskoromilas
Copy link
Contributor Author

rebase

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 51.3s    | 51.0s               |
| enable ingress | 28.2s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 53.1s 50.5s 51.1s 51.2s 50.7s
Times for minikube (PR 12995) start: 51.4s 50.6s 50.7s 51.0s 51.2s

Times for minikube ingress: 30.0s 28.0s 29.6s 25.6s 27.5s
Times for minikube (PR 12995) ingress: 30.0s 28.5s 29.0s 29.1s 25.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 25.2s    | 24.2s               |
| enable ingress | 22.4s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 23.9s 23.0s 21.9s 21.9s 21.4s
Times for minikube (PR 12995) ingress: 21.9s 26.4s 22.9s 21.9s 21.9s

Times for minikube start: 28.7s 24.8s 24.6s 23.7s 24.1s
Times for minikube (PR 12995) start: 23.9s 24.1s 24.8s 24.1s 24.0s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 12995) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 29.7s    | 35.8s ⚠️             |
| enable ingress    | 23.9s    | 27.6s               |
+-------------------+----------+---------------------+

Times for minikube start: 30.2s 28.6s 29.0s 29.1s 31.6s
Times for minikube (PR 12995) start: 27.7s 40.0s 39.9s 28.5s 42.6s

Times for minikube ingress: 22.4s 22.4s 32.5s 22.4s 19.9s
Times for minikube (PR 12995) ingress: 22.4s 22.4s 21.9s 52.4s 18.9s

@eliaskoromilas
Copy link
Contributor Author

Amazon EC2 / f1.2xlarge:

$ env TEST_ARGS="-minikube-start-args=--driver=none -test.run TestAddons" make integration
go test -ldflags="-X k8s.io/minikube/pkg/version.version=v1.26.0-beta.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.26.0-1652998508-14153 -X k8s.io/minikube/pkg/version.gitCommitID="6364518066f0b59081be7e3e269fae24b6e5a948" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -v -test.timeout=90m ./test/integration --tags="integration " -minikube-start-args=--driver=none -test.run TestAddons 2>&1 | tee "./out/testout_636451806.txt"
Found 8 cores, limiting parallelism with --test.parallel=4
=== RUN   TestAddons
=== RUN   TestAddons/Setup
    addons_test.go:77: (dbg) Run:  out/minikube start -p minikube --wait=true --memory=4000 --alsologtostderr --addons=registry --addons=metrics-server --addons=volumesnapshots --addons=csi-hostpath-driver --addons=gcp-auth --driver=none --addons=inaccel --addons=helm-tiller
    addons_test.go:77: (dbg) Done: out/minikube start -p minikube --wait=true --memory=4000 --alsologtostderr --addons=registry --addons=metrics-server --addons=volumesnapshots --addons=csi-hostpath-driver --addons=gcp-auth --driver=none --addons=inaccel --addons=helm-tiller: (44.03978862s)
=== RUN   TestAddons/parallel
=== RUN   TestAddons/parallel/Registry
    addons_test.go:283: registry stabilized in 9.599293ms
    addons_test.go:285: (dbg) TestAddons/parallel/Registry: waiting 6m0s for pods matching "actual-registry=true" in namespace "kube-system" ...
    helpers_test.go:342: "registry-sm64v" [509fd4fc-f218-4bb3-91b4-ba31b711cedf] Running
    addons_test.go:285: (dbg) TestAddons/parallel/Registry: actual-registry=true healthy within 5.008611607s
    addons_test.go:288: (dbg) TestAddons/parallel/Registry: waiting 10m0s for pods matching "registry-proxy=true" in namespace "kube-system" ...
    helpers_test.go:342: "registry-proxy-crtdv" [7d2b748c-441d-4edb-b396-8606e09891cb] Running
    addons_test.go:288: (dbg) TestAddons/parallel/Registry: registry-proxy=true healthy within 5.010031039s
    addons_test.go:293: (dbg) Run:  kubectl --context minikube delete po -l run=registry-test --now
    addons_test.go:298: (dbg) Run:  kubectl --context minikube run --rm registry-test --restart=Never --image=gcr.io/k8s-minikube/busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local"
    addons_test.go:298: (dbg) Done: kubectl --context minikube run --rm registry-test --restart=Never --image=gcr.io/k8s-minikube/busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local": (3.885868251s)
    addons_test.go:312: (dbg) Run:  out/minikube -p minikube ip
2022/05/26 08:20:42 [DEBUG] GET http://172.31.88.36:5000
    addons_test.go:341: (dbg) Run:  out/minikube -p minikube addons disable registry --alsologtostderr -v=1
=== RUN   TestAddons/parallel/Ingress
    addons_test.go:154: skipping: ingress not supported
=== RUN   TestAddons/parallel/MetricsServer
    addons_test.go:360: metrics-server stabilized in 2.561304ms
    addons_test.go:362: (dbg) TestAddons/parallel/MetricsServer: waiting 6m0s for pods matching "k8s-app=metrics-server" in namespace "kube-system" ...
    helpers_test.go:342: "metrics-server-bd6f4dd56-bmfvp" [ec3a9048-2536-4fde-9610-66247b625986] Running
    addons_test.go:362: (dbg) TestAddons/parallel/MetricsServer: k8s-app=metrics-server healthy within 5.0087142s
    addons_test.go:368: (dbg) Run:  kubectl --context minikube top pods -n kube-system
    addons_test.go:385: (dbg) Run:  out/minikube -p minikube addons disable metrics-server --alsologtostderr -v=1
=== RUN   TestAddons/parallel/HelmTiller
    addons_test.go:409: tiller-deploy stabilized in 2.960187ms
    addons_test.go:411: (dbg) TestAddons/parallel/HelmTiller: waiting 6m0s for pods matching "app=helm" in namespace "kube-system" ...
    helpers_test.go:342: "tiller-deploy-6d67d5465d-ttgnd" [a126a203-c236-4806-b21b-1f7ee9275b97] Running
    addons_test.go:411: (dbg) TestAddons/parallel/HelmTiller: app=helm healthy within 5.009746627s
    addons_test.go:426: (dbg) Run:  kubectl --context minikube run --rm helm-test --restart=Never --image=alpine/helm:2.16.3 -it --namespace=kube-system -- version
    addons_test.go:426: (dbg) Done: kubectl --context minikube run --rm helm-test --restart=Never --image=alpine/helm:2.16.3 -it --namespace=kube-system -- version: (3.876973454s)
    addons_test.go:443: (dbg) Run:  out/minikube -p minikube addons disable helm-tiller --alsologtostderr -v=1
=== RUN   TestAddons/parallel/Olm
    addons_test.go:451: Skipping OLM addon test until https://github.com/operator-framework/operator-lifecycle-manager/issues/2534 is resolved
=== RUN   TestAddons/parallel/CSI
    addons_test.go:514: csi-hostpath-driver pods stabilized in 7.266171ms
    addons_test.go:517: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pvc.yaml
    addons_test.go:522: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pvc "hpvc" in namespace "default" ...
    helpers_test.go:392: (dbg) Run:  kubectl --context minikube get pvc hpvc -o jsonpath={.status.phase} -n default
    addons_test.go:527: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pv-pod.yaml
    addons_test.go:532: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pods matching "app=task-pv-pod" in namespace "default" ...
    helpers_test.go:342: "task-pv-pod" [67604232-80ab-4844-b1a7-e0a109f9c6dc] Pending
    helpers_test.go:342: "task-pv-pod" [67604232-80ab-4844-b1a7-e0a109f9c6dc] Pending / Ready:ContainersNotReady (containers with unready status: [task-pv-container]) / ContainersReady:ContainersNotReady (containers with unready status: [task-pv-container])
    helpers_test.go:342: "task-pv-pod" [67604232-80ab-4844-b1a7-e0a109f9c6dc] Running
    addons_test.go:532: (dbg) TestAddons/parallel/CSI: app=task-pv-pod healthy within 11.006956817s
    addons_test.go:537: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/snapshot.yaml
    addons_test.go:542: (dbg) TestAddons/parallel/CSI: waiting 6m0s for volume snapshot "new-snapshot-demo" in namespace "default" ...
    helpers_test.go:417: (dbg) Run:  kubectl --context minikube get volumesnapshot new-snapshot-demo -o jsonpath={.status.readyToUse} -n default
    helpers_test.go:417: (dbg) Run:  kubectl --context minikube get volumesnapshot new-snapshot-demo -o jsonpath={.status.readyToUse} -n default
    addons_test.go:547: (dbg) Run:  kubectl --context minikube delete pod task-pv-pod
    addons_test.go:553: (dbg) Run:  kubectl --context minikube delete pvc hpvc
    addons_test.go:559: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pvc-restore.yaml
    addons_test.go:564: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pvc "hpvc-restore" in namespace "default" ...
    helpers_test.go:392: (dbg) Run:  kubectl --context minikube get pvc hpvc-restore -o jsonpath={.status.phase} -n default
    addons_test.go:569: (dbg) Run:  kubectl --context minikube create -f testdata/csi-hostpath-driver/pv-pod-restore.yaml
    addons_test.go:574: (dbg) TestAddons/parallel/CSI: waiting 6m0s for pods matching "app=task-pv-pod-restore" in namespace "default" ...
    helpers_test.go:342: "task-pv-pod-restore" [b3c379e7-c7da-40a9-8e76-86d0ce40c9e3] Pending
    helpers_test.go:342: "task-pv-pod-restore" [b3c379e7-c7da-40a9-8e76-86d0ce40c9e3] Pending / Ready:ContainersNotReady (containers with unready status: [task-pv-container]) / ContainersReady:ContainersNotReady (containers with unready status: [task-pv-container])
    helpers_test.go:342: "task-pv-pod-restore" [b3c379e7-c7da-40a9-8e76-86d0ce40c9e3] Running
    addons_test.go:574: (dbg) TestAddons/parallel/CSI: app=task-pv-pod-restore healthy within 16.008651545s
    addons_test.go:579: (dbg) Run:  kubectl --context minikube delete pod task-pv-pod-restore
    addons_test.go:579: (dbg) Done: kubectl --context minikube delete pod task-pv-pod-restore: (1.496589616s)
    addons_test.go:583: (dbg) Run:  kubectl --context minikube delete pvc hpvc-restore
    addons_test.go:587: (dbg) Run:  kubectl --context minikube delete volumesnapshot new-snapshot-demo
    addons_test.go:591: (dbg) Run:  out/minikube -p minikube addons disable csi-hostpath-driver --alsologtostderr -v=1
    addons_test.go:591: (dbg) Done: out/minikube -p minikube addons disable csi-hostpath-driver --alsologtostderr -v=1: (6.535659705s)
    addons_test.go:595: (dbg) Run:  out/minikube -p minikube addons disable volumesnapshots --alsologtostderr -v=1
=== RUN   TestAddons/parallel/InAccel
    addons_test.go:728: (dbg) Run:  kubectl --context minikube create --filename testdata/inaccel.yaml
    addons_test.go:733: (dbg) Run:  kubectl --context minikube wait --for condition=ready --timeout -1s pod/inaccel-vadd
    addons_test.go:733: (dbg) Done: kubectl --context minikube wait --for condition=ready --timeout -1s pod/inaccel-vadd: (2.339062155s)
    addons_test.go:737: (dbg) Run:  kubectl --context minikube logs --follow pod/inaccel-vadd
    addons_test.go:737: (dbg) Done: kubectl --context minikube logs --follow pod/inaccel-vadd: (3.554292361s)
    addons_test.go:746: (dbg) Run:  kubectl --context minikube delete pod/inaccel-vadd
=== RUN   TestAddons/serial
=== RUN   TestAddons/serial/GCPAuth
    addons_test.go:606: (dbg) Run:  kubectl --context minikube create -f testdata/busybox.yaml
    addons_test.go:612: (dbg) TestAddons/serial/GCPAuth: waiting 8m0s for pods matching "integration-test=busybox" in namespace "default" ...
    helpers_test.go:342: "busybox" [6f711959-84e6-49a0-9765-9bfaaed88ef3] Pending
    helpers_test.go:342: "busybox" [6f711959-84e6-49a0-9765-9bfaaed88ef3] Pending / Ready:ContainersNotReady (containers with unready status: [busybox]) / ContainersReady:ContainersNotReady (containers with unready status: [busybox])
    helpers_test.go:342: "busybox" [6f711959-84e6-49a0-9765-9bfaaed88ef3] Running
    addons_test.go:612: (dbg) TestAddons/serial/GCPAuth: integration-test=busybox healthy within 8.008634301s
    addons_test.go:618: (dbg) Run:  kubectl --context minikube exec busybox -- /bin/sh -c "printenv GOOGLE_APPLICATION_CREDENTIALS"
    addons_test.go:631: (dbg) Run:  kubectl --context minikube exec busybox -- /bin/sh -c "cat /google-app-creds.json"
    addons_test.go:655: (dbg) Run:  kubectl --context minikube exec busybox -- /bin/sh -c "printenv GOOGLE_CLOUD_PROJECT"
    addons_test.go:668: (dbg) Run:  out/minikube -p minikube addons disable gcp-auth --alsologtostderr -v=1
    addons_test.go:668: (dbg) Done: out/minikube -p minikube addons disable gcp-auth --alsologtostderr -v=1: (5.476207357s)
=== RUN   TestAddons/StoppedEnableDisable
    addons_test.go:135: (dbg) Run:  out/minikube stop -p minikube
    addons_test.go:135: (dbg) Done: out/minikube stop -p minikube: (10.593515674s)
    addons_test.go:139: (dbg) Run:  out/minikube addons enable dashboard -p minikube
    addons_test.go:143: (dbg) Run:  out/minikube addons disable dashboard -p minikube
=== CONT  TestAddons
    helpers_test.go:175: Cleaning up "minikube" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p minikube
    helpers_test.go:178: (dbg) Done: out/minikube delete -p minikube: (4.101684951s)
--- PASS: TestAddons (148.76s)
    --- PASS: TestAddons/Setup (44.04s)
    --- PASS: TestAddons/parallel (75.00s)
        --- PASS: TestAddons/parallel/Registry (14.39s)
        --- SKIP: TestAddons/parallel/Ingress (0.00s)
        --- PASS: TestAddons/parallel/MetricsServer (5.40s)
        --- PASS: TestAddons/parallel/HelmTiller (9.16s)
        --- SKIP: TestAddons/parallel/Olm (0.00s)
        --- PASS: TestAddons/parallel/CSI (39.44s)
        --- PASS: TestAddons/parallel/InAccel (6.61s)
    --- PASS: TestAddons/serial (14.74s)
        --- PASS: TestAddons/serial/GCPAuth (14.74s)
    --- PASS: TestAddons/StoppedEnableDisable (10.87s)
PASS
Tests completed in 2m28.764698942s (result code 0)
ok  	k8s.io/minikube/test/integration	148.863s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 52.6s    | 51.6s               |
| enable ingress | 30.4s    | 30.2s               |
+----------------+----------+---------------------+

Times for minikube start: 54.7s 52.2s 52.2s 52.3s 51.4s
Times for minikube (PR 12995) start: 52.7s 50.4s 51.9s 52.2s 50.9s

Times for minikube ingress: 28.6s 39.6s 29.1s 25.1s 29.6s
Times for minikube (PR 12995) ingress: 30.1s 28.6s 35.1s 28.6s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 28.7s    | 27.7s               |
| enable ingress | 22.8s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 21.6s 23.0s 23.1s 23.6s
Times for minikube (PR 12995) ingress: 23.0s 22.0s 23.1s 23.1s 23.1s

Times for minikube start: 31.0s 26.0s 27.2s 29.0s 30.1s
Times for minikube (PR 12995) start: 26.7s 25.6s 29.3s 27.9s 28.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12995) |
+----------------+----------+---------------------+
| minikube start | 33.0s    | 37.6s               |
| enable ingress | 23.7s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube start: 37.6s 32.5s 33.4s 29.8s 31.9s
Times for minikube (PR 12995) start: 35.6s 43.4s 34.5s 31.7s 42.7s

Times for minikube ingress: 20.6s 23.2s 19.5s 22.0s 33.1s
Times for minikube (PR 12995) ingress: 19.6s 22.1s 29.1s 22.6s 23.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.6/preload-exists (gopogh) n/a
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 0.00 (chart)
Hyperkit_macOS TestKubernetesUpgrade (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/false/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/flannel/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/NetCatPod (gopogh) 0.00 (chart)
Docker_macOS TestAddons/Setup (gopogh) 0.96 (chart)
Docker_macOS TestBinaryMirror (gopogh) 0.96 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 0.96 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/NetCatPod (gopogh) 1.30 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 1.92 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 2.22 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 15.18 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh) 15.18 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 15.18 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Stop (gopogh) 15.18 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh) 15.18 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 21.74 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 23.46 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 36.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 36.96 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 39.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 44.57 (chart)
Docker_Windows TestAddons/Setup (gopogh) 48.57 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.6/preload-exists (gopogh) n/a
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 0.00 (chart)
Docker_macOS TestPause/serial/VerifyStatus (gopogh) 0.00 (chart)
Docker_macOS TestPreload (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/NetCatPod (gopogh) 0.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 1.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 1.01 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 1.92 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 9.09 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 11.11 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 12.12 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 16.16 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 18.56 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 23.89 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 23.89 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 23.89 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 23.89 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 23.89 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 23.89 (chart)
Docker_Linux_containerd TestPreload (gopogh) 23.89 (chart)
Docker_Linux_containerd TestOffline (gopogh) 27.43 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 27.43 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 37.17 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit 1f76335 into kubernetes:master Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliaskoromilas, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees

@spowelljr spowelljr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eliaskoromilas @k8s-ci-robot @minikube-bot @spowelljr @k8s-triage-robot @sharifelgamal @minikube-pr-bot