Added --name flag and MINIKUBE_NAME env var for vm machine name

[aaron-prindle]

This allows users to specify the vm name for minikube to allow for multiple minikubeVMs to be created. This enables multiple minikubes to be managed on a single machine.

Example use:

$ minikube start --name=test
$ minikube start --name=test2
#VM created w/ name test
$ minikube status --name=test
$ minikube status --name=test2
$ minikube delete --name=test
$ minikube delete --name=test2

$ minikube start --name=test
$ minikube start --name=test2
$ minikube config set name test
$ minikube status
$ minikube logs
....
$ minikube config set name test2
$ minikube status
$ minikube logs
....

[codecov-io]

Codecov Report

Merging #1320 into master will decrease coverage by 0.02%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   43.06%   43.03%   -0.03%     
==========================================
  Files          48       48              
  Lines        2271     2277       +6     
==========================================
+ Hits          978      980       +2     
- Misses       1133     1137       +4     
  Partials      160      160

Impacted Files	Coverage Δ
pkg/minikube/config/config.go	32.14% <0%> (-5.36%)	⬇️
cmd/minikube/cmd/start.go	21.31% <0%> (ø)	⬆️
pkg/minikube/cluster/cluster_linux.go	0% <0%> (ø)	⬆️
cmd/minikube/cmd/ip.go	11.76% <0%> (ø)	⬆️
cmd/minikube/cmd/env.go	68% <100%> (ø)	⬆️
cmd/minikube/cmd/root.go	68.33% <100%> (+1.09%)	⬆️
pkg/minikube/cluster/cluster.go	55% <55%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce80e5...1b79cfd. Read the comment docs.

[dlorenc]

Can we move this from constants to config?

[aaron-prindle]

done

[aaron-prindle]

@minikube-bot retest this please

[aaron-prindle]

@minikube-bot retest this please

[aaron-prindle]

@minikube-bot retest this please

[r2d4]

Might be worth it to switch the env getting to use viper, since then we also get the config file for free. Either way, LGTM

[r2d4]

Why not just use viper.GetString here? Viper looks at env vars, so you could call it minikube-name and that would translate to MINIKUBE_NAME

I think we should also add this to minikube config set/unset

[aaron-prindle]

done. Also added "--name" as a flag to all minikube commands

[aaron-prindle]

Fixes #886

[jorgemoralespou]

Although I live the feature had been finally implemented, I have to say that how to set the active instance/VM is not really easy and friendly.
I would rather simplify that action to Ann easier command.
"minikube activate " or something similar, which is a single command and provide a name to easily identify the action.

Also I would think that using shortcut for options sound be allowed.

minikube start --name=test
minikube start -n test

[aaron-prindle]

@jorgemoralespou minikube activate <name> would seem to be very similar to the current minikube config set name <name> which works currently. Is the minikube config set name <name> command sufficient for your workflow? I agree that -n seems like a reasonable shortcut for this, if you'd like you can submit a feature request or PR.

[jorgemoralespou]

@aaron-prindle my main concern is about user experience. I find minikube config set name <name> not use friendly and not self explanatory.

For the -n I would submit a PR but I'm no go developer so better if I don't 😉 I'll open a feature request.

[jemc]

For anyone else who saw this and expected to be able to use the --name argument in the latest minikube release, it appears to have been renamed as --profile.

[gbraad]

^^ this is due to #1466 "Changed --name to --profile / -p"

[fhemberger]

@aaron-prindle @jorgemoralespou Hi, found this PR through Google while looking for this feature, it says, that this change was released in v0.20.0, however minikube start --help doesn't list the switch. Am I missing something?

[aaron-prindle]

@fhemberger --profile is a global flag to all minikube commands, it would be at the end of the minikube start --help in the Global Flags: section of the output:

aprindle@aprindle:$ minikube start --help | grep profile
  -p, --profile string                   The name of the minikube VM being used.

This flag can be used in all minikube commands, it is not strictly a start flag.

[fhemberger]

@aaron-prindle Ah, great. Thanks! 👍

[qafro1]

So What's the commands for multiple minikubes ?

[lindhe]

Is this feature removed?