Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Kong Ingress Controller #13326

Merged
merged 5 commits into from
Feb 1, 2022
Merged

Conversation

gAmUssA
Copy link
Contributor

@gAmUssA gAmUssA commented Jan 11, 2022

A new addon for Kong Ingress Controller (KIC) https://github.com/Kong/kubernetes-ingress-controller.

Kong Ingress Controller works inside a Kubernetes cluster and configures Kong to proxy traffic as per rules defined in the
Ingress resources. This addon enables KIC for local development and testing of services that require Ingress object.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 11, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @gAmUssA!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @gAmUssA. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 11, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 11, 2022

@k8s-ci-robot /check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 11, 2022
@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 11, 2022

/assign @afbjorklund

@sharifelgamal
Copy link
Collaborator

Hey @gAmUssA, thanks for the PR! Could you templatize the images in the yaml and add the pinned references to pkg/minikube/assets/addons.go?

See https://github.com/kubernetes/minikube/blob/master/deploy/addons/gcp-auth/gcp-auth-webhook.yaml.tmpl#L131 and https://github.com/kubernetes/minikube/blob/master/pkg/minikube/assets/addons.go#L541 for an example on how it's done.

fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
image: kong/kubernetes-ingress-controller:2.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR,

would u plz add the image sha to the image name, to ensure the integrity of this image

@gAmUssA gAmUssA requested a review from medyagh January 18, 2022 15:13
@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 18, 2022

Team, @medyagh @sharifelgamal
Sorry for delay. I addressed mentioned comments in 88d15c2
Thank you

@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 25, 2022

Team
Could you kindly take a look at this PR? @medyagh @sharifelgamal

@medyagh
Copy link
Member

medyagh commented Jan 25, 2022

@gAmUssA sorry for the delay, do u mind adding a doc page on this our website of how to use this add-on ?
maybe a page under https://minikube.sigs.k8s.io/docs/handbook/addons/

and would u plz add example usage of this addon to the PR description ? and what it is used for ?

@medyagh
Copy link
Member

medyagh commented Jan 25, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 45.4s    | 44.1s               |
| enable ingress | 28.8s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 48.8s 45.1s 43.9s 44.2s 45.0s
Times for minikube (PR 13326) start: 44.1s 44.7s 44.1s 43.6s 43.8s

Times for minikube ingress: 28.6s 25.6s 30.1s 30.5s 29.0s
Times for minikube (PR 13326) ingress: 28.6s 28.6s 31.6s 30.1s 31.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 26.8s    | 26.4s               |
| enable ingress | 23.3s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.9s 25.4s 23.0s 23.4s 22.9s
Times for minikube (PR 13326) ingress: 21.9s 21.9s 22.4s 22.9s 22.9s

Times for minikube start: 29.4s 26.7s 26.2s 26.8s 24.8s
Times for minikube (PR 13326) start: 27.0s 26.8s 25.8s 26.0s 26.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 45.3s               |
| enable ingress | 21.6s    | 19.0s               |
+----------------+----------+---------------------+

Times for minikube start: 32.6s 45.4s 41.5s 45.0s 41.3s
Times for minikube (PR 13326) start: 44.7s 45.9s 44.9s 45.7s 45.3s

Times for minikube ingress: 23.4s 18.9s 23.4s 18.9s 23.4s
Times for minikube (PR 13326) ingress: 18.9s 18.9s 18.9s 19.4s 18.9s

@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 25, 2022

@medyagh I added tutorial via 5cc50e6. Let me know if it looks ok.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 46.0s    | 45.5s               |
| enable ingress | 28.4s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 46.2s 44.8s 45.7s 50.1s 43.2s
Times for minikube (PR 13326) start: 43.4s 45.2s 50.2s 44.3s 44.6s

Times for minikube ingress: 29.1s 25.5s 29.1s 29.1s 29.1s
Times for minikube (PR 13326) ingress: 30.0s 25.5s 28.5s 28.6s 29.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 26.6s    | 26.4s               |
| enable ingress | 22.0s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 26.1s 29.2s 26.9s 25.2s 25.9s
Times for minikube (PR 13326) start: 26.2s 26.1s 27.1s 26.4s 26.3s

Times for minikube ingress: 21.9s 21.9s 21.9s 21.9s 22.4s
Times for minikube (PR 13326) ingress: 22.9s 21.9s 22.4s 22.0s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 42.9s    | 43.2s               |
| enable ingress | 21.7s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube start: 45.4s 46.0s 41.3s 41.2s 40.7s
Times for minikube (PR 13326) start: 44.6s 44.9s 40.8s 45.2s 40.6s

Times for minikube (PR 13326) ingress: 19.9s 19.4s 23.9s 18.9s 23.4s
Times for minikube ingress: 19.4s 18.9s 23.4s 23.4s 23.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.2/preload-exists (gopogh) n/a
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) n/a
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
Docker_macOS TestCertExpiration (gopogh) 0.00 (chart)
Docker_macOS TestCertOptions (gopogh) 0.00 (chart)
Docker_macOS TestDockerFlags (gopogh) 0.00 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 0.00 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 0.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 0.00 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 0.00 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 0.00 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 0.00 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 0.00 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.2/preload-exists (gopogh) n/a
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 0.00 (chart)
KVM_Linux TestNoKubernetes/serial/StartWithK8s (gopogh) 0.00 (chart)
KVM_Linux TestNoKubernetes/serial/StartWithStopK8s (gopogh) 0.00 (chart)
KVM_Linux TestNetworkPlugins/group/kubenet/Start (gopogh) 11.11 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 12.50 (chart)
KVM_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 22.22 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 33.33 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/DeployApp (gopogh) 33.33 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 33.33 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/FirstStart (gopogh) 33.33 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 50.00 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 66.67 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 66.67 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 66.67 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 66.67 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 87.50 (chart)
Docker_macOS TestSkaffold (gopogh) 87.50 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 100.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 28, 2022

@medyagh Let me know if there is something missing from my side. Thank you

@gAmUssA
Copy link
Contributor Author

gAmUssA commented Jan 31, 2022

dear @medyagh @sharifelgamal @afbjorklund
did you have a chance to look at it? Is there anything else I should look into here?

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@sharifelgamal
Copy link
Collaborator

I'm going to rerun our integration test suite, and if everything looks good, this PR should be good to merge.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 45.3s    | 45.6s               |
| enable ingress | 31.2s    | 33.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 13326) ingress: 31.6s 30.0s 46.6s 29.1s 31.1s
Times for minikube ingress: 29.6s 30.1s 32.6s 31.6s 32.1s

Times for minikube start: 45.8s 45.5s 44.7s 45.1s 45.4s
Times for minikube (PR 13326) start: 44.7s 50.2s 44.2s 45.1s 43.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 26.2s    | 25.6s               |
| enable ingress | 25.7s    | 24.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13326) start: 25.7s 25.2s 25.6s 26.2s 25.2s
Times for minikube start: 27.6s 26.2s 25.9s 25.1s 26.2s

Times for minikube ingress: 28.4s 28.4s 23.9s 22.9s 24.9s
Times for minikube (PR 13326) ingress: 25.9s 22.9s 23.9s 24.9s 25.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13326) |
+----------------+----------+---------------------+
| minikube start | 40.4s    | 42.0s               |
| enable ingress | 29.2s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.9s 42.3s 42.0s 41.7s 45.1s
Times for minikube (PR 13326) start: 41.3s 41.5s 45.2s 41.0s 41.0s

Times for minikube ingress: 27.4s 46.4s 26.9s 25.4s 20.0s
Times for minikube (PR 13326) ingress: 37.4s 29.9s 19.9s 33.4s 23.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Pause (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/NetCatPod (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/calico/NetCatPod (gopogh) 6.06 (chart)
KVM_Linux_containerd TestForceSystemdEnv (gopogh) 9.72 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 11.32 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 12.00 (chart)
KVM_Linux_containerd TestCertExpiration (gopogh) 12.50 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 13.46 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 17.81 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/flannel/Start (gopogh) 18.06 (chart)
Docker_Windows TestNetworkPlugins/group/auto/DNS (gopogh) 18.37 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Pause (gopogh) 18.75 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 19.44 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 20.75 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 22.22 (chart)
Docker_Linux_containerd TestOffline (gopogh) 28.00 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 28.00 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 30.00 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 30.00 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 30.00 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 30.00 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 30.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 30.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gAmUssA, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@sharifelgamal
Copy link
Collaborator

Thank you for contributing to minikube!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants