Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Delete and init kubeadm on subsequent starts" #13506

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Revert "Delete and init kubeadm on subsequent starts" #13506

merged 2 commits into from
Feb 1, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jan 27, 2022 •
edited

Fixes #13431
Fixes #13503
Related #12389

Reverting my original PR #13121 as it's causing a regression.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@spowelljr spowelljr mentioned this pull request Jan 31, 2022
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13506) |
+----------------+----------+---------------------+
| minikube start | 46.2s    | 46.0s               |
| enable ingress | 30.0s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.6s 30.6s 31.1s 29.5s 29.1s
Times for minikube (PR 13506) ingress: 25.6s 26.1s 29.1s 29.1s 28.5s

Times for minikube start: 52.0s 44.5s 44.4s 44.4s 45.7s
Times for minikube (PR 13506) start: 45.5s 45.1s 45.4s 50.3s 43.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13506) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 26.1s               |
| enable ingress | 22.4s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube start: 28.7s 26.0s 25.2s 26.4s 25.8s
Times for minikube (PR 13506) start: 25.8s 25.7s 26.0s 26.4s 26.7s

Times for minikube ingress: 21.4s 21.9s 23.9s 22.4s 22.4s
Times for minikube (PR 13506) ingress: 25.4s 22.5s 21.9s 23.4s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13506) |
+----------------+----------+---------------------+
| minikube start | 43.1s    | 44.0s               |
| enable ingress | 28.4s    | 24.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 13506) start: 45.4s 45.9s 41.9s 46.0s 40.8s
Times for minikube start: 36.6s 46.0s 42.3s 44.8s 45.6s

Times for minikube ingress: 50.9s 29.0s 23.4s 19.9s 18.9s
Times for minikube (PR 13506) ingress: 18.9s 28.9s 32.9s 18.9s 23.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/Setup (gopogh) 1.39 (chart)
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) 1.85 (chart)
Hyper-V_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 3.70 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 4.17 (chart)
Docker_macOS TestNetworkPlugins/group/auto/DNS (gopogh) 5.00 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 7.04 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 18.06 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 20.90 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 27.12 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 34.25 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 34.62 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 45.83 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 61.29 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 61.97 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 62.50 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 65.28 (chart)
Docker_Linux TestNetworkPlugins/group/calico/DNS (gopogh) 75.00 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 81.94 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 83.33 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 84.72 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 100.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13506) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 44.4s               |
| enable ingress | 28.0s    | 27.6s               |
+----------------+----------+---------------------+

Times for minikube start: 45.7s 43.8s 43.8s 44.0s 43.8s
Times for minikube (PR 13506) start: 45.0s 44.7s 44.0s 44.1s 44.4s

Times for minikube (PR 13506) ingress: 25.0s 28.6s 29.5s 30.1s 25.0s
Times for minikube ingress: 28.5s 27.0s 26.0s 29.0s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13506) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 25.9s               |
| enable ingress | 22.8s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13506) ingress: 22.4s 22.5s 23.4s 22.9s 26.4s
Times for minikube ingress: 22.9s 23.4s 22.9s 22.9s 21.9s

Times for minikube start: 29.8s 25.2s 25.1s 25.5s 26.1s
Times for minikube (PR 13506) start: 25.1s 26.3s 26.3s 26.1s 25.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13506) |
+----------------+----------+---------------------+
| minikube start | 42.5s    | 42.4s               |
| enable ingress | 20.2s    | 24.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 24.4s 18.9s 20.0s 18.9s 18.9s
Times for minikube (PR 13506) ingress: 20.9s 18.9s 24.4s 22.9s 33.4s

Times for minikube start: 30.8s 45.2s 44.9s 45.6s 46.0s
Times for minikube (PR 13506) start: 43.8s 44.8s 41.7s 40.7s 41.2s

@spowelljr spowelljr merged commit 48065d9 into kubernetes:master Feb 1, 2022
@spowelljr spowelljr deleted the revertKubeadmDelete branch February 1, 2022 21:40
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 12.28 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 21.57 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 25.00 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 35.59 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 42.50 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 42.50 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 54.24 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 60.34 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 61.02 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 61.02 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 65.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/DNS (gopogh) 73.68 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 74.58 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 78.75 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 82.50 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 82.50 (chart)
Docker_Windows TestAddons/parallel/MetricsServer (gopogh) 86.44 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 100.00 (chart)
Docker_Windows TestNoKubernetes/serial/Start (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr mentioned this pull request Feb 18, 2022
Closed
@shaima-mahmoud
Copy link

Hello, I am a beginner with minikube and linux as well, how to I upgrade from 1.25 version to this version on linux ?

@spowelljr
Copy link
Member Author

Hello, I am a beginner with minikube and linux as well, how to I upgrade from 1.25 version to this version on linux ?

Hi @shaima-mahmoud, follow the instructions in our documentation, thanks!

https://minikube.sigs.k8s.io/docs/start/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@klaases klaases Awaiting requested review from klaases

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pods not started after minikube restart (minikube v1.25.X, docker driver) Error while configuring RBAC rules
5 participants
@spowelljr @k8s-ci-robot @minikube-pr-bot @sharifelgamal @shaima-mahmoud