add arch to binary and image cache paths #13539
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Co-authored-by: Medya Ghazizadeh <medyagh@users.noreply.github.com>
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 45.7s 44.9s 43.5s 43.0s 44.5s Times for minikube ingress: 29.6s 29.5s 25.6s 25.6s 33.1s docker driver with docker runtime Times for minikube start: 27.0s 25.8s 25.7s 25.9s 25.8s Times for minikube ingress: 83.4s 22.9s 22.9s 23.9s 22.4s docker driver with containerd runtime Times for minikube ingress: 24.4s 23.4s 29.4s 24.4s 24.9s Times for minikube (PR 13539) start: 41.0s 44.8s 46.2s 41.0s 40.5s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
We might have to include the "iso" here as well, right @klaases ? Otherwise we have to rename the "minikube.iso" artifact instead. |
|
kvm2 driver with docker runtime Times for minikube start: 46.5s 44.3s 45.3s 44.6s 44.1s Times for minikube ingress: 28.6s 29.1s 30.1s 30.0s 28.5s docker driver with docker runtime Times for minikube start: 30.5s 25.6s 26.0s 27.2s 26.1s Times for minikube ingress: 23.4s 22.4s 21.9s 23.0s 21.9s docker driver with containerd runtime Times for minikube start: 30.5s 41.8s 40.4s 40.5s 41.3s Times for minikube ingress: 23.4s 53.4s 28.4s 34.4s 24.4s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
kvm2 driver with docker runtime Times for minikube start: 55.1s 52.4s 52.4s 52.1s 51.5s Times for minikube (PR 13539) ingress: 29.6s 25.6s 28.5s 28.6s 29.1s docker driver with docker runtime Times for minikube start: 30.4s 26.0s 27.3s 26.0s 26.3s Times for minikube (PR 13539) ingress: 21.9s 21.9s 22.0s 22.4s 22.9s docker driver with containerd runtime Times for minikube start: 35.4s 45.5s 42.1s 45.7s 41.7s Times for minikube (PR 13539) ingress: 18.9s 23.4s 29.9s 19.9s 19.9s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
minikube 1.25.2 moved the downloaded kubectl and other binaries to a new subdir; it now includes runtime.GOARCH as an extra component. See-also: kubernetes/minikube#13539 Signed-off-by: Niels de Vos <ndevos@redhat.com>
minikube 1.25.2 moved the downloaded kubectl and other binaries to a new subdir; it now includes runtime.GOARCH as an extra component. See-also: kubernetes/minikube#13539 Signed-off-by: Niels de Vos <ndevos@redhat.com>
This path adds an extra directory to the cache baths for important minikube binary and image cache paths. This will allow users to run multiple arch binaries without corrupting their cache. Note that this does not affect preloads in any way.
Fixes #9593
Fixes #12274