Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Upgrade crio to 1.22.3 #13800

Merged
merged 2 commits into from
Mar 28, 2022
Merged

ISO: Upgrade crio to 1.22.3 #13800

merged 2 commits into from
Mar 28, 2022

Conversation

afbjorklund
Copy link
Collaborator

No description provided.

@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
klaases
klaases approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @afbjorklund!

@medyagh
Copy link
Member

medyagh commented Mar 23, 2022

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/13800/24825a5/iso_build.txt

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13800) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 51.9s               |
| enable ingress | 28.1s    | 27.6s               |
+----------------+----------+---------------------+

Times for minikube start: 54.0s 54.1s 52.5s 52.5s 52.4s
Times for minikube (PR 13800) start: 51.7s 52.0s 52.5s 51.5s 51.6s

Times for minikube ingress: 24.5s 29.0s 28.6s 30.0s 28.5s
Times for minikube (PR 13800) ingress: 25.5s 28.5s 29.5s 28.6s 26.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13800) |
+----------------+----------+---------------------+
| minikube start | 26.7s    | 26.0s               |
| enable ingress | 35.6s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 30.4s 25.7s 25.7s 25.7s 25.8s
Times for minikube (PR 13800) start: 26.8s 25.4s 25.2s 26.2s 26.1s

Times for minikube (PR 13800) ingress: 22.9s 21.4s 22.9s 21.9s 23.9s
Times for minikube ingress: 83.4s 24.9s 21.9s 23.9s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13800) |
+----------------+----------+---------------------+
| minikube start | 39.5s    | 42.2s               |
| enable ingress | 23.7s    | 21.3s               |
+----------------+----------+---------------------+

Times for minikube start: 29.7s 40.9s 41.2s 40.4s 45.3s
Times for minikube (PR 13800) start: 44.7s 41.9s 41.1s 41.5s 41.9s

Times for minikube ingress: 23.4s 32.4s 22.4s 22.4s 17.9s
Times for minikube (PR 13800) ingress: 17.9s 21.9s 22.5s 22.4s 21.9s

@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2022
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestPause/serial/PauseAgain (gopogh) 0.00 (chart)
Docker_Windows TestMissingContainerUpgrade (gopogh) 0.80 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/Stop (gopogh) 1.59 (chart)
Docker_macOS TestDockerFlags (gopogh) 6.54 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 6.54 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 6.54 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 6.59 (chart)
Docker_macOS TestCertExpiration (gopogh) 7.19 (chart)
Docker_macOS TestCertOptions (gopogh) 7.19 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 7.19 (chart)
Docker_macOS TestDownloadOnly/v1.23.3/preload-exists (gopogh) 7.19 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 9.15 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 12.42 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 12.42 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 12.42 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 13.10 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 13.79 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 15.03 (chart)
Docker_Windows TestSkaffold (gopogh) 15.20 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 15.69 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 16.55 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 16.55 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 16.55 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 16.67 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 16.67 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 16.67 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 17.24 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 17.27 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 19.28 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 19.58 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13800) |
+----------------+----------+---------------------+
| minikube start | 54.4s    | 54.0s               |
| enable ingress | 29.4s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.6s 29.6s 29.1s 28.1s 30.6s
Times for minikube (PR 13800) ingress: 29.1s 28.6s 29.6s 30.1s 30.1s

Times for minikube start: 56.6s 53.6s 54.6s 53.5s 53.5s
Times for minikube (PR 13800) start: 53.1s 54.1s 54.0s 53.2s 55.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13800) |
+----------------+----------+---------------------+
| minikube start | 26.6s    | 27.2s               |
| enable ingress | 22.5s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 26.7s 26.3s 26.5s 26.9s 26.6s
Times for minikube (PR 13800) start: 27.2s 26.7s 27.8s 26.6s 27.5s

Times for minikube ingress: 21.9s 23.0s 22.5s 22.4s 22.5s
Times for minikube (PR 13800) ingress: 23.0s 22.0s 22.0s 23.0s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13800) |
+----------------+----------+---------------------+
| minikube start | 44.4s    | 44.6s               |
| enable ingress | 22.1s    | 20.0s               |
+----------------+----------+---------------------+

Times for minikube start: 47.0s 42.3s 46.0s 44.9s 41.6s
Times for minikube (PR 13800) start: 42.1s 42.1s 46.6s 46.0s 46.1s

Times for minikube ingress: 18.0s 23.5s 27.9s 19.0s 21.9s
Times for minikube (PR 13800) ingress: 22.4s 22.1s 18.0s 19.0s 18.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
KVM_Linux TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.57 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.57 (chart)
Docker_Linux TestForceSystemdFlag (gopogh) 0.60 (chart)
KVM_Linux TestRunningBinaryUpgrade (gopogh) 4.00 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 7.14 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 7.74 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 13.70 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 19.16 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 22.16 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 22.16 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 22.16 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 22.16 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 22.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 22.16 (chart)
Docker_Linux_containerd TestPreload (gopogh) 22.16 (chart)
Docker_Linux_containerd TestOffline (gopogh) 27.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 30.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 30.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 30.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 30.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 30.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 30.54 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit c9ed082 into kubernetes:master Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@klaases klaases klaases approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@afbjorklund @medyagh @minikube-bot @minikube-pr-bot @k8s-ci-robot @spowelljr @klaases