Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registry when custom images provided #14690

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Fix registry when custom images provided #14690

merged 4 commits into from
Aug 11, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Aug 1, 2022 •
edited

Related: #14521

Before:

minikube addons enable dashboard --images=MetricsScraper=k8s.gcr.io/echoserver:1.4
...
# Resulting (incorrect) image: docker.io/k8s.gcr.io/echoserver:1.4

After:

minikube addons enable dashboard --images=MetricsScraper=k8s.gcr.io/echoserver:1.4
...
# Resulting (correct) image: k8s.gcr.io/echoserver:1.4

Don't use default registry if custom image is defined.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 0 with minikube (PR 14690): timing cmd: [/home/jenkins/.minikube/minikube-binaries/14690/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with docker runtime
error downloading artifacts: artifact download start: exit status 81docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_Linux_containerd TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
Docker_macOS TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_Windows TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/NetCatPod (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
none_Linux TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Hyperkit_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 1.31 (chart)
Hyperkit_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 1.31 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/DeployApp (gopogh) 1.31 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 1.31 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/FirstStart (gopogh) 1.31 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 5.56 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 10.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 18.57 (chart)
Docker_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 28.57 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 32.10 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 32.86 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 55.07 (chart)
Docker_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 55.41 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 55.71 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 56.1s    | 56.7s               |
| enable ingress | 27.5s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube start: 57.6s 56.4s 54.2s 56.2s 56.3s
Times for minikube (PR 14690) start: 56.2s 59.3s 57.6s 55.2s 55.5s

Times for minikube ingress: 25.6s 25.6s 30.1s 29.6s 26.6s
Times for minikube (PR 14690) ingress: 30.2s 25.1s 25.0s 28.1s 30.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 28.2s    | 27.9s               |
| enable ingress | 22.3s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube start: 27.8s 27.6s 28.1s 28.5s 29.1s
Times for minikube (PR 14690) start: 27.8s 28.0s 28.7s 27.1s 27.9s

Times for minikube ingress: 23.4s 21.4s 22.0s 23.0s 21.5s
Times for minikube (PR 14690) ingress: 23.0s 22.9s 21.9s 24.5s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 25.9s               |
| enable ingress | 27.3s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube start: 24.0s 23.1s 24.3s 35.4s 23.3s
Times for minikube (PR 14690) start: 23.2s 23.1s 23.8s 24.1s 35.4s

Times for minikube (PR 14690) ingress: 27.5s 27.0s 27.5s 27.0s 27.5s
Times for minikube ingress: 27.0s 27.0s 27.5s 27.4s 27.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.59 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 0.59 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.62 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 1.37 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 1.37 (chart)
Hyper-V_Windows TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 1.37 (chart)
Hyper-V_Windows TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 1.37 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 2.96 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 7.69 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 10.69 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 11.33 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 11.33 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 11.33 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/NetCatPod (gopogh) 20.69 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 55.4s    | 55.6s               |
| enable ingress | 26.6s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 55.9s 55.3s 55.2s 54.8s 55.7s
Times for minikube (PR 14690) start: 56.6s 55.4s 55.5s 55.1s 55.2s

Times for minikube (PR 14690) ingress: 28.1s 25.1s 28.5s 25.6s 28.6s
Times for minikube ingress: 24.6s 28.6s 29.1s 25.5s 25.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 27.2s    | 27.4s               |
| enable ingress | 22.6s    | 24.6s               |
+----------------+----------+---------------------+

Times for minikube start: 26.7s 27.8s 27.5s 26.3s 27.9s
Times for minikube (PR 14690) start: 26.8s 28.8s 27.7s 26.1s 27.7s

Times for minikube ingress: 21.5s 22.5s 22.0s 24.4s 22.5s
Times for minikube (PR 14690) ingress: 22.5s 30.0s 22.9s 23.0s 24.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 23.4s               |
| enable ingress | 29.4s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 14690) start: 23.0s 24.0s 23.5s 23.0s 23.6s
Times for minikube start: 23.8s 23.6s 24.2s 24.4s 23.9s

Times for minikube ingress: 27.4s 27.5s 27.4s 37.4s 27.5s
Times for minikube (PR 14690) ingress: 27.5s 27.4s 26.9s 27.0s 26.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnlyKic (gopogh) 6.83 (chart)
Docker_macOS TestDownloadOnly/v1.24.3/preload-exists (gopogh) 9.57 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 10.49 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 13.19 (chart)
Docker_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 22.22 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 23.61 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 34.72 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 37.35 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 40.35 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 40.87 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 41.38 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 41.88 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 46.48 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 47.37 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 47.37 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 47.37 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 48.28 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 56.94 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 57.02 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 57.39 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 57.75 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 57.76 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 58.12 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 66.67 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 73.68 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 75.44 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 79.67 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 81.60 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 87.50 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 87.50 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 56.4s    | 56.1s               |
| enable ingress | 27.0s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 55.9s 57.4s 55.0s 57.2s 56.7s
Times for minikube (PR 14690) start: 53.5s 57.0s 56.8s 56.5s 56.8s

Times for minikube ingress: 25.6s 25.6s 29.1s 28.6s 26.1s
Times for minikube (PR 14690) ingress: 25.6s 30.1s 25.1s 29.6s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 28.2s    | 28.3s               |
| enable ingress | 23.6s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 28.3s 27.8s 27.9s 28.1s 28.6s
Times for minikube (PR 14690) start: 28.2s 27.3s 28.0s 28.6s 29.5s

Times for minikube ingress: 22.4s 26.5s 22.5s 23.0s 23.5s
Times for minikube (PR 14690) ingress: 22.0s 23.0s 23.5s 23.0s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14690) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 23.9s               |
| enable ingress | 29.4s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 14690) start: 23.9s 23.3s 24.9s 24.0s 23.3s
Times for minikube start: 23.4s 22.6s 23.4s 34.2s 23.8s

Times for minikube ingress: 27.5s 37.5s 27.4s 27.4s 27.0s
Times for minikube (PR 14690) ingress: 26.9s 27.5s 27.0s 27.0s 37.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestPause/serial/PauseAgain (gopogh) 4.48 (chart)
Hyperkit_macOS TestFunctional/parallel/ConfigCmd (gopogh) 5.33 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 5.36 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 29.41 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 29.41 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 30.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 30.58 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 39.50 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 39.50 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 39.50 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 40.00 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 40.76 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 44.54 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 45.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 45.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 45.45 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 47.06 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 53.62 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 69.57 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 69.75 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 73.79 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.15 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 77.69 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 84.14 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 85.52 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 87.59 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 88.97 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 95.95 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 98.64 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

klaases
klaases approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for clarifying the change

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit aff7efa into kubernetes:master Aug 11, 2022
@spowelljr spowelljr deleted the fixCustomImage branch August 11, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spowelljr @minikube-pr-bot @k8s-ci-robot @klaases