--kubernetes-version add support for checking github k8s versions and exit nicely on error #16865

JudahNour · 2023-07-11T14:50:50Z

Before:

$ mk start --kubernetes-version=v1.28.0-alpha.5
😄  minikube v1.30.1 on Debian rodete (amd64)
❗  Specified Kubernetes version 1.28.0-alpha.5 is newer than the newest supported version: v1.27.3. Use `minikube config defaults kubernetes-version` for details.
✨  Automatically selected the docker driver
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=8000MB) ...
❗  The image 'registry.k8s.io/kube-scheduler:v1.28.0-alpha.5' was not found; unable to add it to cache.
❗  The image 'registry.k8s.io/kube-apiserver:v1.28.0-alpha.5' was not found; unable to add it to cache.
❗  The image 'registry.k8s.io/kube-controller-manager:v1.28.0-alpha.5' was not found; unable to add it to cache.
❗  The image 'registry.k8s.io/kube-proxy:v1.28.0-alpha.5' was not found; unable to add it to cache.
🐳  Preparing Kubernetes v1.28.0-alpha.5 on Docker 24.0.2 ...
❌  Unable to load cached images: loading cached images: stat /usr/local/google/home/judahn/.minikube/cache/images/amd64/registry.k8s.io/kube-apiserver_v1.28.0-alpha.5: no such file or directory

❌  Exiting due to K8S_INSTALL_FAILED: Failed to update cluster: updating control plane: downloading binaries: downloading kubectl: download failed: https://dl.k8s.io/release/v1.28.0-alpha.5/bin/linux/amd64/kubectl?checksum=file:https://dl.k8s.io/release/v1.28.0-alpha.5/bin/linux/amd64/kubectl.sha256: getter: &{Ctx:context.Background Src:https://dl.k8s.io/release/v1.28.0-alpha.5/bin/linux/amd64/kubectl?checksum=file:https://dl.k8s.io/release/v1.28.0-alpha.5/bin/linux/amd64/kubectl.sha256 Dst:/usr/local/google/home/judahn/.minikube/cache/linux/amd64/v1.28.0-alpha.5/kubectl.download Pwd: Mode:2 Umask:---------- Detectors:[0x3f01040 0x3f01040 0x3f01040 0x3f01040 0x3f01040 0x3f01040 0x3f01040] Decompressors:map[bz2:0xc000238490 gz:0xc000238498 tar:0xc000238440 tar.bz2:0xc000238450 tar.gz:0xc000238460 tar.xz:0xc000238470 tar.zst:0xc000238480 tbz2:0xc000238450 tgz:0xc000238460 txz:0xc000238470 tzst:0xc000238480 xz:0xc0002384a0 zip:0xc0002384b0 zst:0xc0002384a8] Getters:map[file:0xc001552bd0 http:0xc00070b590 https:0xc00070b5e0] Dir:false ProgressListener:0x3ec1760 Insecure:false DisableSymlinks:false Options:[0x1c0d8e0]}: invalid checksum: Error downloading checksum file: bad response code: 404

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

After:

$ mk start --kubernetes-version=v1.28.0-alpha.5
😄  minikube v1.30.1 on Debian rodete (amd64)
❗  Specified Kubernetes version 1.28.0-alpha.5 is newer than the newest supported version: v1.27.3. Use `minikube config defaults kubernetes-version` for details.
❗  Specified Kubernetes version 1.28.0-alpha.5 not found in Kubernetes version list. Searching the internet...
❗  Kubernetes version not found in Github version list. You can force a Kubernetes version via the --force flag

❌  Exiting due to K8S_NEW_UNSUPPORTED: Kubernetes 1.28.0-alpha.5 is not supported by this release of minikube

Before:

$ mk start --kubernetes-version=v1.28.0-alpha.4
😄  minikube v1.30.1 on Debian rodete (amd64)
❗  Specified Kubernetes version 1.28.0-alpha.4 is newer than the newest supported version: v1.27.3. Use `minikube config defaults kubernetes-version` for details.
✨  Automatically selected the docker driver
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=8000MB) ...
🐳  Preparing Kubernetes v1.28.0-alpha.4 on Docker 24.0.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring CNI (Container Networking Interface) ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

After:

$ mk start --kubernetes-version=v1.28.0-alpha.4
😄  minikube v1.30.1 on Debian rodete (amd64)
❗  Specified Kubernetes version 1.28.0-alpha.4 is newer than the newest supported version: v1.27.3. Use `minikube config defaults kubernetes-version` for details.
❗  Specified Kubernetes version 1.28.0-alpha.4 not found in Kubernetes version list. Searching the internet...
✅  Kubernetes version 1.28.0-alpha.4 found in Github version list
✨  Automatically selected the docker driver
📌  Using Docker driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=8000MB) ...
🐳  Preparing Kubernetes v1.28.0-alpha.4 on Docker 24.0.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring CNI (Container Networking Interface) ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

k8s-ci-robot · 2023-07-11T14:50:59Z

Hi @JudahNour. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2023-07-11T14:51:04Z

Can one of the admins verify this patch?

cmd/minikube/cmd/config/kubernetes_version.go

cmd/minikube/cmd/start.go

pkg/minikube/reason/reason.go

cmd/minikube/cmd/start.go

medyagh · 2023-07-12T19:42:20Z

$ mk start --kubernetes-version=v1.28.0-alpha.4
😄  minikube v1.30.1 on Debian rodete (amd64)
❗  Specified Kubernetes version 1.28.0-alpha.4 is newer than the newest supported version: v1.27.3. Use `minikube config defaults kubernetes-version` for details.
❗  Specified Kubernetes version 1.28.0-alpha.4 not found in Kubernetes version list. Searching the internet...

second one should not be Warnining Icon it is searching...

cmd/minikube/cmd/config/kubernetes_version.go

cmd/minikube/cmd/start.go

spowelljr · 2023-07-13T20:20:10Z

Need to rebase to fix the merge conflict

…makeErrorBetter

spowelljr · 2023-07-14T17:15:45Z

Something went wrong with your rebase, there's a bunch of file changes here now

…Better

JudahNour · 2023-07-14T17:26:44Z

Something went wrong with your rebase, there's a bunch of file changes here now

I believe this is fixed but I'm trying to fix an issue that I think rebasing again just caused

Edit: done

spowelljr · 2023-08-17T17:37:45Z

/ok-to-test

pkg/minikube/reason/reason.go

minikube-pr-bot · 2023-08-17T21:45:05Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16865) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 51.6s               |
| enable ingress | 27.5s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 50.2s 48.9s 51.8s 51.2s 52.1s
Times for minikube (PR 16865) start: 52.9s 50.2s 50.3s 51.9s 53.0s

Times for minikube ingress: 26.7s 28.3s 27.8s 27.2s 27.7s
Times for minikube (PR 16865) ingress: 28.3s 26.3s 27.7s 27.7s 27.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16865) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 23.2s               |
| enable ingress | 20.8s    | 21.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.8s 20.9s 20.4s 20.9s 20.8s
Times for minikube (PR 16865) ingress: 20.8s 20.3s 24.3s 20.8s 21.9s

Times for minikube start: 24.7s 25.4s 24.7s 22.8s 22.3s
Times for minikube (PR 16865) start: 24.8s 21.6s 24.3s 21.3s 23.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16865) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 20.5s               |
| enable ingress | 28.8s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 19.9s 23.4s 23.4s 19.7s
Times for minikube (PR 16865) start: 22.5s 19.7s 20.0s 20.2s 20.1s

Times for minikube ingress: 31.3s 19.3s 31.4s 31.4s 30.3s
Times for minikube (PR 16865) ingress: 31.3s 31.4s 31.3s 30.3s 31.4s

k8s-ci-robot · 2023-08-17T22:08:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JudahNour, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2023-08-18T01:10:02Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_crio	TestFunctional/parallel/ImageCommands/ImageRemove (gopogh)	0.76 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	1.46 (chart)
Docker_Linux_containerd_arm64	TestFunctional/serial/ExtraConfig (gopogh)	3.50 (chart)
Docker_Linux_containerd_arm64	TestFunctional/serial/ComponentHealth (gopogh)	4.20 (chart)
Hyperkit_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	4.38 (chart)
KVM_Linux_crio	TestFunctional/serial/LogsFileCmd (gopogh)	26.72 (chart)

To see the flake rates of all tests by environment, click here.

add support for checking github k8s versions

54d1939

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2023

k8s-ci-robot requested review from afbjorklund and prezha July 11, 2023 14:50

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2023

spowelljr requested changes Jul 11, 2023

View reviewed changes

cmd/minikube/cmd/config/kubernetes_version.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/config/kubernetes_version.go Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023

use GetReleaseByTag to speed up version searching

a3bf353

spowelljr requested changes Jul 12, 2023

View reviewed changes

cmd/minikube/cmd/config/kubernetes_version.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

pkg/minikube/reason/reason.go Outdated Show resolved Hide resolved

spowelljr requested changes Jul 12, 2023

View reviewed changes

cmd/minikube/cmd/start.go Show resolved Hide resolved

refactor code and fix typos

111acc8

create separate message for internet search

c205355

spowelljr requested changes Jul 13, 2023

View reviewed changes

cmd/minikube/cmd/config/kubernetes_version.go Show resolved Hide resolved

spowelljr requested changes Jul 13, 2023

View reviewed changes

cmd/minikube/cmd/config/kubernetes_version.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

adding added files to automation for github package

42552bf

spowelljr approved these changes Jul 13, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023

JudahNour added 6 commits July 13, 2023 20:26

add support for checking github k8s versions

f0ba218

use GetReleaseByTag to speed up version searching

7ebd776

refactor code and fix typos

6c9b4b2

create separate message for internet search

aa0a915

adding added files to automation for github package

ed906c2

Merge branch 'makeErrorBetter' of github.com:JudahNour/minikube into …

a9b5972

…makeErrorBetter

k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2023

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 13, 2023

Merge branch 'master' of github.com:JudahNour/minikube into makeError…

c7b2561

…Better

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2023

fix duplication

af9184b

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2023

This comment has been minimized.

Sign in to view

spowelljr requested changes Aug 17, 2023

View reviewed changes

pkg/minikube/reason/reason.go Outdated Show resolved Hide resolved

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023

add internet error exit code when failing to fetch version list

e527c94

spowelljr approved these changes Aug 17, 2023

View reviewed changes

spowelljr merged commit 5753ca0 into kubernetes:master Aug 17, 2023
16 of 29 checks passed

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

--kubernetes-version add support for checking github k8s versions and exit nicely on error #16865

--kubernetes-version add support for checking github k8s versions and exit nicely on error #16865

JudahNour commented Jul 11, 2023 •

edited

k8s-ci-robot commented Jul 11, 2023

minikube-bot commented Jul 11, 2023

medyagh commented Jul 12, 2023

spowelljr commented Jul 13, 2023

spowelljr commented Jul 14, 2023

JudahNour commented Jul 14, 2023 •

edited

spowelljr commented Aug 17, 2023

This comment has been minimized.

This comment has been minimized.

minikube-pr-bot commented Aug 17, 2023

k8s-ci-robot commented Aug 17, 2023

minikube-pr-bot commented Aug 18, 2023

--kubernetes-version add support for checking github k8s versions and exit nicely on error #16865

--kubernetes-version add support for checking github k8s versions and exit nicely on error #16865

Conversation

JudahNour commented Jul 11, 2023 • edited

Before:

After:

Before:

After:

k8s-ci-robot commented Jul 11, 2023

minikube-bot commented Jul 11, 2023

medyagh commented Jul 12, 2023

spowelljr commented Jul 13, 2023

spowelljr commented Jul 14, 2023

JudahNour commented Jul 14, 2023 • edited

spowelljr commented Aug 17, 2023

This comment has been minimized.

This comment has been minimized.

minikube-pr-bot commented Aug 17, 2023

k8s-ci-robot commented Aug 17, 2023

minikube-pr-bot commented Aug 18, 2023

JudahNour commented Jul 11, 2023 •

edited

JudahNour commented Jul 14, 2023 •

edited