Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make error look nicer when user enters a too new that doesnt exist #16607

Closed
medyagh opened this issue May 31, 2023 · 2 comments · Fixed by #16865
Closed

make error look nicer when user enters a too new that doesnt exist #16607

medyagh opened this issue May 31, 2023 · 2 comments · Fixed by #16865
Assignees
Labels
kind/improvement Categorizes issue or PR as related to improving upon a current feature.

Comments

@medyagh
Copy link
Member

medyagh commented May 31, 2023

What Happened?

for example if you do
minikube start --kuberentes-version=1.26.99

minikube should first look up the kuberentes version in our supported versions in constants packages
if it is not there then it should heads up to the users we will try to fetch it from internet, and if it failed it should fail nicely

@medyagh
Copy link
Member Author

medyagh commented May 31, 2023

so when the k8s versio is not in the Constants we will try to fetch it from the deleted code in this PR https://github.com/kubernetes/minikube/pull/16571/files

and if it is not there, will be just Exit without trying (unless the user says --force)

@medyagh medyagh added the kind/improvement Categorizes issue or PR as related to improving upon a current feature. label May 31, 2023
@JudahNour
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Categorizes issue or PR as related to improving upon a current feature.
Projects
None yet
2 participants