Kic: Add "no-limit" option to cpus & memory flags

[spowelljr]

$ minikube start --cpus=no-limit --memory=no-limit
😄  minikube v1.31.2 on Darwin 14.0 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh
📌  Using Docker Desktop driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=no-limit, Memory=no-limit) ...
🐳  Preparing Kubernetes v1.28.3 on Docker 24.0.6 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

Can see that --memory & --cpus not present in docker run command

I1025 16:07:12.318937     694 cli_runner.go:164] Run: docker run -d -t --privileged --security-opt seccomp=unconfined --tmpfs /tmp --tmpfs /run -v /lib/modules:/lib/modules:ro --hostname minikube --name minikube --label created_by.minikube.sigs.k8s.io=true --label name.minikube.sigs.k8s.io=minikube --label role.minikube.sigs.k8s.io= --label mode.minikube.sigs.k8s.io=minikube --network minikube --ip 192.168.49.2 --volume minikube:/var --security-opt apparmor=unconfined -e container=docker --expose 8443 --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 --publish=127.0.0.1::32443 gcr.io/k8s-minikube/kicbase-builds:v0.0.40-1698055645-17423@sha256:fb2566ae68d58d9dce5cb4087954a42bedc9f0c47c18aef3d28a238a8beeb883

Trying to use flag value on non-kic driver will result in an error

$ minikube start --driver qemu --cpus=no-limit
😄  minikube v1.31.2 on Darwin 14.0 (arm64)
✨  Using the qemu2 driver based on user configuration

❌  Exiting due to MK_USAGE: The 'qemu2' driver does not support --cpus=no-limit

$ minikube start --driver qemu --memory=no-limit
😄  minikube v1.31.2 on Darwin 14.0 (arm64)
✨  Using the qemu2 driver based on user configuration

❌  Exiting due to MK_USAGE: The 'qemu2' driver does not support --memory=no-limit

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17491) |
+----------------+----------+---------------------+
| minikube start | 50.2s    | 49.7s               |
| enable ingress | 25.8s    | 24.5s               |
+----------------+----------+---------------------+

Times for minikube start: 50.0s 50.6s 49.5s 49.9s 51.0s
Times for minikube (PR 17491) start: 50.5s 48.8s 50.3s 51.0s 47.8s

Times for minikube ingress: 27.1s 23.2s 27.6s 24.1s 27.1s
Times for minikube (PR 17491) ingress: 23.1s 23.6s 27.7s 23.5s 24.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17491) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 23.7s               |
| enable ingress | 19.9s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.7s 22.1s 22.4s 22.2s 25.2s
Times for minikube (PR 17491) start: 24.1s 21.9s 24.2s 24.0s 24.2s

Times for minikube ingress: 20.8s 21.9s 18.9s 19.8s 18.4s
Times for minikube (PR 17491) ingress: 20.8s 20.8s 21.8s 20.8s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17491) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.6s               |
| enable ingress | 31.4s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 23.4s 20.7s 24.4s 21.0s
Times for minikube (PR 17491) start: 20.9s 23.6s 23.6s 23.7s 21.1s

Times for minikube ingress: 31.4s 31.3s 31.3s 31.4s 31.4s
Times for minikube (PR 17491) ingress: 18.3s 31.3s 32.3s 31.4s 31.3s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_crio	TestAddons/parallel/InspektorGadget (gopogh)	0.00 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	0.00 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	0.00 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh)	1.43 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	1.43 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	1.43 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	1.43 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh)	1.43 (chart)
Hyperkit_macOS	TestRunningBinaryUpgrade (gopogh)	15.38 (chart)

To see the flake rates of all tests by environment, click here.