Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addons: Update Inspektor Gadget entrypoint and cleanup. #17740

Merged
merged 1 commit into from Dec 7, 2023
Merged

addons: Update Inspektor Gadget entrypoint and cleanup. #17740

merged 1 commit into from Dec 7, 2023

Conversation

eiffel-fl
Copy link
Contributor

Hi!

Inspektor Gadget container entrypoint and cleanup programs were translated from
bash to golang [1, 2].
Upstream YAML file used to deploy was updated to reflect this change [3].

Sadly, it was not the case for the YAML used to deploy the minikube addon which
leaded to troubles [4, 5, 6].

The present commit updates the minikube addon YAML to use the correct programs
as entrypoint and cleanup.

Best regards.

[1]: https://github.com/inspektor-gadget/inspektor-gadget/commit/b268d38758cfc175a9fc7bddea82c937e9668542
[2]: https://github.com/inspektor-gadget/inspektor-gadget/commit/3dba83f2ebe8cb8d08dbe1b81ab0cb24531fe5b0
[3]: https://github.com/inspektor-gadget/inspektor-gadget/commit/992399f2ddd3392615860b75d6251ac3e1706231#diff-0927404b80a3c13f63de64a0c7af1833ba3dfd4b4e1dd07b09cb8216c7f033fcR46
[4]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio_arm64.html#fail_TestAddons/parallel/InspektorGadget
[5]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
[6]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/KVM_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @eiffel-fl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@eiffel-fl eiffel-fl mentioned this pull request Dec 6, 2023
Closed
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2023
@eiffel-fl
Addon inspektor-gadget: Update inspektor-gadget image from v0.22.0 to…
6db73b2 
… v0.23.1

This commit bumps Inspektor Gadget addon from v0.22.0 to v0.23.1.
To avoid deployment failures, we also need to update the YAML.

Indeed, Inspektor Gadget container entrypoint and cleanup programs were
translated from bash to golang [1, 2].
Upstream YAML file used to deploy was updated to reflect this change [3].

Sadly, it was not the case for the YAML used to deploy the minikube addon which
leaded to troubles [4, 5, 6].

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
[1]: inspektor-gadget/inspektor-gadget@b268d38
[2]: inspektor-gadget/inspektor-gadget@3dba83f
[3]: inspektor-gadget/inspektor-gadget@992399f#diff-0927404b80a3c13f63de64a0c7af1833ba3dfd4b4e1dd07b09cb8216c7f033fcR46
[4]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio_arm64.html#fail_TestAddons/parallel/InspektorGadget
[5]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
[6]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/KVM_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
@spowelljr spowelljr mentioned this pull request Dec 6, 2023
Closed
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 4 with minikube (PR 17740): timing cmd: [/home/jenkins/.minikube/minikube-binaries/17740/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 90
docker driver with docker runtime
error downloading artifacts: artifact download start: exit status 81docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/parallel/Registry (gopogh) 1.18 (chart)
Docker_Linux_docker_arm64 TestMissingContainerUpgrade (gopogh) 1.76 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 2.40 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 2.99 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 3.23 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 3.29 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr
spowelljr approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks for the help updating the addon!

@spowelljr spowelljr merged commit 02e1bff into kubernetes:master Dec 7, 2023
23 of 38 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eiffel-fl, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@eiffel-fl
Copy link
Contributor Author

Thank you for the merge! I will close the corresponding issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eiffel-fl @k8s-ci-robot @minikube-bot @spowelljr @minikube-pr-bot