Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'none' shell for docker-env output #1792

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Aug 4, 2017

This is for consumers who want the key/value output, but don't need the
shell directives.

Sample output

$ minikube docker-env --shell none
DOCKER_TLS_VERIFY=1
DOCKER_HOST=tcp://192.168.39.124:2376
DOCKER_CERT_PATH=/home/mrick/.minikube/certs
DOCKER_API_VERSION=1.23

$ minikube docker-env --shell none -u
DOCKER_TLS_VERIFY=
DOCKER_HOST=
DOCKER_CERT_PATH=
DOCKER_API_VERSION=

cc @loosebazooka

This is for consumers who want the key/value output, but don't need the
shell directives.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2017
@codecov-io
Copy link

Codecov Report

Merging #1792 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   37.27%   37.16%   -0.12%     
==========================================
  Files          51       51              
  Lines        3367     3377      +10     
==========================================
  Hits         1255     1255              
- Misses       1929     1939      +10     
  Partials      183      183
Impacted Files Coverage Δ
cmd/minikube/cmd/env.go 56.8% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde62b5...a02541d. Read the comment docs.

@r2d4 r2d4 merged commit 55fb939 into kubernetes:master Aug 7, 2017
@r2d4 r2d4 deleted the docker-env-helper branch August 7, 2017 16:50
@loosebazooka
Copy link

🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants