Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): Bump github.com/docker/cli from 26.0.2+incompatible to 26.1.1+incompatible #18821

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 6, 2024

Bumps github.com/docker/cli from 26.0.2+incompatible to 26.1.1+incompatible.

Commits
  • 4cf5afa Merge pull request #5047 from vvoland/v26.1-5038
  • 6c2b06d Merge pull request #5045 from vvoland/vendor-docker-26.1.1-dev
  • 1c6a8ec cli-plugins: PluginRunCommand: use cmd.Environ instead of os.Environ
  • 6d1c387 vendor: github.com/docker/docker ac2de55998d4 (v26.1.1)
  • 1e6db5d Merge pull request #5044 from vvoland/wait-cancel-noerror
  • 840016e waitExitOrRemoved: Handle context cancellation
  • 9714adc Merge pull request #5034 from vvoland/vendor-docker
  • aec1d36 vendor: github.com/docker/docker v26.1.0-dev (c8af8ebe4a89)
  • e397e50 Merge pull request #5033 from laurazard/hooks-error-message
  • 43cb06e hooks: pass command execution error to plugins
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 6, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented May 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

Bumps [github.com/docker/cli](https://github.com/docker/cli) from 26.0.2+incompatible to 26.1.1+incompatible.
- [Commits](docker/cli@v26.0.2...v26.1.1)

---
updated-dependencies:
- dependency-name: github.com/docker/cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/docker/cli-26.1.1incompatible branch from f13ce1c to c4bf245 Compare May 8, 2024 18:06
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18821) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 53.0s               |
| enable ingress | 27.6s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube start: 55.2s 50.5s 50.6s 51.5s 49.6s
Times for minikube (PR 18821) start: 54.2s 52.6s 53.1s 49.5s 55.7s

Times for minikube ingress: 27.7s 28.0s 28.5s 25.6s 28.0s
Times for minikube (PR 18821) ingress: 26.1s 25.5s 25.1s 29.1s 28.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18821) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 24.1s               |
| enable ingress | 21.7s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 24.9s 22.5s 22.6s 25.0s
Times for minikube (PR 18821) start: 22.6s 25.1s 21.9s 25.2s 25.7s

Times for minikube ingress: 21.4s 21.4s 21.8s 21.8s 22.3s
Times for minikube (PR 18821) ingress: 25.3s 22.3s 22.3s 21.8s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18821) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.3s               |
| enable ingress | 32.0s    | 32.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 20.7s 23.2s 20.7s 23.6s
Times for minikube (PR 18821) start: 21.7s 22.8s 21.0s 21.3s 24.6s

Times for minikube ingress: 31.8s 31.9s 31.8s 31.8s 32.8s
Times for minikube (PR 18821) ingress: 31.8s 31.8s 31.9s 48.3s 19.8s

@medyagh
Copy link
Member

medyagh commented May 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@medyagh medyagh merged commit 9e63e8f into master May 8, 2024
27 of 40 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/docker/cli-26.1.1incompatible branch May 8, 2024 22:17
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestFunctional/parallel/DashboardCmd (gopogh) n/a
Docker_Windows TestFunctional/parallel/ServiceCmdConnect (gopogh) n/a
Docker_Windows TestFunctional/parallel/TunnelCmd/serial (gopogh) n/a
Docker_Windows TestFunctional/parallel/UpdateContextCmd (gopogh) n/a
Docker_Linux_docker_arm64 TestScheduledStopUnix (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.20.0/DeleteAlwaysSucceeds (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.30.0/DeleteAll (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.30.0/DeleteAlwaysSucceeds (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/AddonsCmd (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageRemove (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/License (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ProfileCmd/profile_json_output (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ProfileCmd/profile_list (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ProfileCmd/profile_not_create (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd/List (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants