Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the source of libmachine to machine-drivers. #3185

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Switch the source of libmachine to machine-drivers. #3185

merged 1 commit into from
Oct 1, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Sep 28, 2018

The two are still identical, so there's not much of a difference yet.

Fixes #3019

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2018
@tstromberg
Copy link
Contributor

This might be a flake, but the HyperKit errors look unusual:

	(minikube) DBG | virtio_net: Could not create vmnet interface, permission denied or no entitlement?
	E0928 14:00:42.807711    6724 start.go:168] Error starting host: Error creating host: Error creating machine: Error in driver during machine creation: getting MAC address from UUID: vmnet: error from vmnet.framework: -1

@dlorenc
Copy link
Contributor Author

dlorenc commented Sep 29, 2018

Reran the hyperkit one manually and got it to pass, but for some reason the status check is still showing red:
https://storage.googleapis.com/minikube-builds/logs/3185/OSX-Hyperkit.txt

balopat
balopat approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlorenc dlorenc merged commit 55afd08 into kubernetes:master Oct 1, 2018
@dlorenc dlorenc deleted the machine-drivers branch October 1, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @k8s-ci-robot @tstromberg @balopat