Add images and improve parsing for kubernetes 1.11 #3262
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Can one of the admins verify this patch? |
mlgibbons
changed the title
|
/assign tstromberg |
|
@minikube-bot OK to test |
tstromberg
added
the
approved
|
This change addresses some issues with the list of images which were cached for K8S v1.11.0 and which were detected during additional offline testing. An issue has been raised against kubeadm - kubernetes/kubeadm#1198 - in relation to the incorrect images being returned for coredns and pause. |
|
Bug confirmed in kubeadm 1.11 and fixed in 1.12 - kubernetes/kubeadm#1198 - see comment in issue. |
|
@minikube-bot OK to test |
|
@minikube-bot OK to test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mlgibbons, RA489 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tstromberg I'm wondering what is preventing this from being merged? What's the next step? |
|
Sorry for the delay - we needed to take some time to stabilize our CI infrastructure. Will review after test results are updated. |
|
@minikube-bot OK to test |
|
@tstromberg Thanks. I see that the changes are approved but I'm unclear if the tests which are required are complete - there seem to be a lot pending. We need to upgrade to our minikube version to 0.32 to address a dashboard CVE but need this change in there hence my desire to understand when they'll be merged to master. Thanks. |
|
@minikube-bot OK to test |
1 similar comment
|
@minikube-bot OK to test |
Updated parsing logic to handle K8S v1.11 in same fashion as other versions