Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade the version of cached images #3289

Closed
wants to merge 1 commit into from

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Nov 1, 2018

upgrade the version of cached images

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Nov 1, 2018

/assign @tstromberg

@RA489
Copy link

RA489 commented Nov 1, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RA489, SataQiu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

1 similar comment
@SataQiu
Copy link
Member Author

SataQiu commented Nov 2, 2018

@minikube-bot OK to test

@mlgibbons
Copy link
Contributor

I just stumbled across this PR this morning and it looks like this conflicts (right term?) with #3262 in the v1.11 section. What is the process for detecting/resolving this kind of concurrent change?

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@SataQiu SataQiu closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants