Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warn if kvm driver version is old #4676

Merged

Conversation

josedonizetti
Copy link
Member

issue: #4658

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2019
@josedonizetti
Copy link
Member Author

@medyagh Let me know what you think about the changes. I've added a constant to the kvm documentation, we could start enforcing it everywhere we link to the documentation, that way if we need to change one day, it's a single change.

I'll try to simplify the documentation now. Although I'm intrigued the PR #4681 make this one unnecessary.

@medyagh
Copy link
Member

medyagh commented Jul 4, 2019

I think this PR could be used to detect the too old KVM drivers that we want to enforce the upgrade ( before the user waits a few minutes till the error happen) if we know the kvm driver is too old. we should end gracefuly without error.

the other PR is good when minikube crashes with an error. it is meant as an after-happened handling, so we have less support ticket.

so this is PR is still helpful and needed to detect sooner

@josedonizetti
Copy link
Member Author

@medyagh I've added an upgrade section to the KVM documentation. I know you mentioned we had too many ifs, but it kind of seems necessary to explain about dependencies, and possible problems with libvirtd. Wdyt?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2019
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@medyagh
Copy link
Member

medyagh commented Jul 4, 2019

@minikube-bot OK to test

@medyagh medyagh merged commit cc99602 into kubernetes:master Jul 5, 2019
@josedonizetti josedonizetti deleted the warn-if-kvm2-version-is-old branch July 5, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants