Ensures that we get the same IP between start/delete #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xhyve driver added support for the UUID flag in xhyve machine-drivers/docker-machine-driver-xhyve#133 Fixes kubernetes#516
|
We'll need to remember this if we ever decide to run multiple minikubes on the same machine, but LGTM for now. |
Current coverage is 30.30% (diff: 100%)@@ master #517 diff @@
==========================================
Files 39 39
Lines 1594 1594
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 483 483
Misses 1003 1003
Partials 108 108
|
| @@ -22,6 +22,9 @@ import ( | |||
| "k8s.io/minikube/pkg/minikube/constants" | |||
| ) | |||
|
|
|||
| // Ensures that we get assigned the same IP across deletes/starts | |||
There was a problem hiding this comment.
Was this just randomly generated?
There was a problem hiding this comment.
Yeah using uuidgen on OS X
|
LGTM |
|
ref #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xhyve driver added support for the UUID flag in xhyve
machine-drivers/docker-machine-driver-xhyve#133
Fixes #516
It would be nice to add an integration test for this once (if) we can get this behavior with the other drivers.