Support using the configured UUID instead of always generating a UUID… #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that you can reuse IP addresses for hosts.
chirino
added a commit
to chirino/minishift
that referenced
this pull request
Aug 24, 2016
… you will get same IP address again. Depends on the xhyve driver merging the following PR: machine-drivers/docker-machine-driver-xhyve#133
|
@chirino Thanks for the pull request! It seems LGTM, but now xhyve driver has not configure Thanks. Edit: I means like |
|
Yep it's related to minikube/shift see: minishift/minishift#53 |
|
@chirino Thanks :) |
|
@chirino I'm wait for ci result... |
chirino
added a commit
to chirino/minishift
that referenced
this pull request
Aug 24, 2016
… you will get same IP address again. Depends on the xhyve driver merging the following PR: machine-drivers/docker-machine-driver-xhyve#133
|
@chirino @jimmidyson merged. Thanks :) |
|
Awesome! Thanks for a great project btw 🍻 |
|
@jimmidyson yey \o/ |
|
@jimmidyson @dlorenc I think maybe kubenetes team and minikube/minishift like to use release version. |
|
We certainly do want to use it! Whenever you get a chance to release that would be great. Thanks! |
r2d4
added a commit
to r2d4/minikube
that referenced
this pull request
Aug 24, 2016
The xhyve driver added support for the UUID flag in xhyve machine-drivers/docker-machine-driver-xhyve#133 Fixes kubernetes#516
r2d4
added a commit
to r2d4/minikube
that referenced
this pull request
Sep 19, 2016
The xhyve driver added support for the UUID flag in xhyve machine-drivers/docker-machine-driver-xhyve#133 Fixes kubernetes#516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so that you can reuse IP addresses for hosts.