Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizing Chinese translation #5201

Merged
merged 3 commits into from
Oct 17, 2019

Conversation

BlackHole1
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @BlackHole1!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @BlackHole1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlackHole1
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RA489
Copy link

RA489 commented Aug 30, 2019

/check-cla

@tstromberg
Copy link
Contributor

@BlackHole1 - Please visit https://identity.linuxfoundation.org/projects/cncf to sign the CLA. Thank you!

@BlackHole1
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 6, 2019
@tstromberg
Copy link
Contributor

This looks good. Can it be merged yet?

@BlackHole1
Copy link
Contributor Author

I am also thinking about this problem because I found in the process of translation that if all the keywords are translated, some programmers in mainland China may not be able to go to google well. Because most of the problems on google are in English, if you search in Chinese, you may get nothing.

I'd like to hear your opinion. @tstromberg

@tstromberg
Copy link
Contributor

Getting the problems translated would be nice, but not necessary for the first PR: there is a lot of text there.

@BlackHole1
Copy link
Contributor Author

@tstromberg Ok, but please wait a few days, I'm adding some.

@priyawadhwa
Copy link

Hey @BlackHole1, thanks for opening this PR. We recently updated some of these translations, so you'll have to rebase your PR and fix any merge conflicts. Other than that, is this ready to be merged?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2019
@BlackHole1
Copy link
Contributor Author

@priyawadhwa @tstromberg hi guys. This branch has rebased the latest master branch code. And perfect a little translation. Now it can be merged.

@BlackHole1 BlackHole1 changed the title (WIP): optimizing Chinese translation optimizing Chinese translation Oct 10, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #5201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5201   +/-   ##
=======================================
  Coverage   36.86%   36.86%           
=======================================
  Files         102      102           
  Lines        7349     7349           
=======================================
  Hits         2709     2709           
  Misses       4289     4289           
  Partials      351      351

@priyawadhwa
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2019
@tstromberg tstromberg merged commit 5a75e97 into kubernetes:master Oct 17, 2019
@tstromberg
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants