Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check image versions with the none driver (no crictl) #6050

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

tstromberg
Copy link
Contributor

Fixes last-minute breakage with an integration test added in #6043

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@medyagh
Copy link
Member

medyagh commented Dec 11, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #6050 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6050   +/-   ##
=======================================
  Coverage   36.74%   36.74%           
=======================================
  Files         113      113           
  Lines        8366     8366           
=======================================
  Hits         3074     3074           
  Misses       4890     4890           
  Partials      402      402

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 127.019536 130.671889 118.679024]
All Times Minikube (PR 6050): [ 131.294777 127.618709 126.372953]

Average minikube: 125.456816
Average Minikube (PR 6050): 128.428813

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6050) |
+----------------------+-----------+--------------------+
| minikube v           |  0.347387 |           0.344301 |
| Creating kvm2        | 49.642608 |          49.314540 |
| Preparing Kubernetes | 48.031733 |          51.571506 |
| Pulling images       |  3.773361 |           2.860277 |
| Launching Kubernetes | 20.424208 |          21.203826 |
| Waiting for cluster  |  2.591095 |           3.084552 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Dec 11, 2019

not related tot his but I see kvm duration is much more than vbox ! it used to be the other way

@tstromberg tstromberg merged commit 8666e22 into kubernetes:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants